Closed
Bug 170951
Opened 22 years ago
Closed 19 years ago
IME should use OS system color for selection instead of inverting
Categories
(Core :: Internationalization, defect, P1)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: Brade, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
(Keywords: inputmethod, intl)
Attachments
(2 obsolete files)
When typing with IME, I expect it to use the system color rather than inverting. I spoke with Frank Tang briefly and he said it'd be ok to submit a patch that was not OS specific to use the system selection color instead of inverting the rect.
Reporter | ||
Comment 1•22 years ago
|
||
This patch leaves the old code available (via #if 0) for the time being. I hesitate to remove it entirely until it has landed and there are no major complaints on any platforms. Simon--I intend to land this on the Chimera branch, please sr= for trunk as well as Chimera branch.
Comment 3•22 years ago
|
||
Doesn't cocoa have its own color (yellow) for such selection? Should we add to nsILookAndFeel to get this color?
this code looks like it should work. put me for an r= if you like. I talked to kathy and I suggested that maybe putting an #if IME_INVERT instead of the #if 0 and adding the #if !IME_INVERT around all the new code. so we can quickly compile it one way or the other. then once ime users can whack on the new way and it passes mustard, we remove all the #ifs. however you decide is cool.
Comment 5•22 years ago
|
||
r=pink, but use an ifdef label rather than #if 0 so we know what's going on and can find it more easily later.
Reporter | ||
Comment 7•22 years ago
|
||
Comment on attachment 101163 [details] [diff] [review] updated patch which landed on Chimera branch carry forward r= from pinkerton and mjudge
Attachment #101163 -
Flags: review+
Attachment (id=101163) once landed on Chimera 1.7.1 branch, but didn't land on trunk. Are there any problems?
Assignee | ||
Comment 10•20 years ago
|
||
This patch should not be check-in to Trunk. Because it is XP source code, not for only Mac. Please wait, I will re-implement IME composition string rendering soon.
Assignee | ||
Comment 12•20 years ago
|
||
I take this bug.
Assignee: brade → masayuki
Component: Editor → Internationalization
Keywords: intl
Priority: -- → P2
QA Contact: sujay → amyy
Target Milestone: --- → mozilla1.9alpha
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Priority: P2 → P1
Assignee | ||
Updated•20 years ago
|
Attachment #101163 -
Attachment is obsolete: true
Assignee | ||
Comment 14•19 years ago
|
||
fixed by bug 113161. -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Keywords: inputmethod
You need to log in
before you can comment on or make changes to this bug.
Description
•