When typing with IME, I expect it to use the system color rather than inverting. I spoke with Frank Tang briefly and he said it'd be ok to submit a patch that was not OS specific to use the system selection color instead of inverting the rect.
Created attachment 100717 [details] [diff] [review] patch to hilite IME with selection color instead of inverting This patch leaves the old code available (via #if 0) for the time being. I hesitate to remove it entirely until it has landed and there are no major complaints on any platforms. Simon--I intend to land this on the Chimera branch, please sr= for trunk as well as Chimera branch.
*** Bug 170950 has been marked as a duplicate of this bug. ***
Doesn't cocoa have its own color (yellow) for such selection? Should we add to nsILookAndFeel to get this color?
this code looks like it should work. put me for an r= if you like. I talked to kathy and I suggested that maybe putting an #if IME_INVERT instead of the #if 0 and adding the #if !IME_INVERT around all the new code. so we can quickly compile it one way or the other. then once ime users can whack on the new way and it passes mustard, we remove all the #ifs. however you decide is cool.
r=pink, but use an ifdef label rather than #if 0 so we know what's going on and can find it more easily later.
Created attachment 101163 [details] [diff] [review] updated patch which landed on Chimera branch
Attachment #100717 - Attachment is obsolete: true
Comment on attachment 101163 [details] [diff] [review] updated patch which landed on Chimera branch carry forward r= from pinkerton and mjudge
Attachment #101163 - Flags: review+
*** Bug 236996 has been marked as a duplicate of this bug. ***
Attachment (id=101163) once landed on Chimera 1.7.1 branch, but didn't land on trunk. Are there any problems?
This patch should not be check-in to Trunk. Because it is XP source code, not for only Mac. Please wait, I will re-implement IME composition string rendering soon.
*** Bug 159263 has been marked as a duplicate of this bug. ***
Depends on: 236996
I take this bug.
Assignee: brade → masayuki
Component: Editor → Internationalization
Priority: -- → P2
QA Contact: sujay → amyy
Target Milestone: --- → mozilla1.9alpha
Status: NEW → ASSIGNED
Priority: P2 → P1
Attachment #101163 - Attachment is obsolete: true
Depends on: 307396
Depends on: 307532
*** Bug 312838 has been marked as a duplicate of this bug. ***
fixed by bug 113161. -> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
8 years ago
You need to log in before you can comment on or make changes to this bug.