1131725 - Intermittent run-by-dir test_9999_cleanup.xul | application crashed [@ nsSocketTransport::InitiateSocket()] from "FATAL ERROR: Non-local network connections are disabled and a connection attempt to aus4.mozilla.org (63.245.217.219) was made."

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

04:03:29 INFO - 3406 INFO TEST-START | toolkit/mozapps/update/tests/chrome/test_9999_cleanup.xul
04:03:29 INFO - ++DOMWINDOW == 211 (0x99d8d6d0) [pid = 11418] [serial = 692] [outer = 0x9cd9a4f0]
04:03:29 INFO - 04:03:29:298 | TEST-INFO | chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/test_9999_cleanup.xul | [runTest : 34] entering
04:03:29 INFO - 04:03:29:309 | TEST-INFO | chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/utils.js | [removeDirRecursive : 1075] attempting to remove directory. Path: /tmp/tmpv1fbi8.mozrunner/appupdateprep
04:03:29 INFO - 04:03:29:311 | TEST-INFO | chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/utils.js | [resetAddons : 2207] entering
04:03:30 INFO - 3407 INFO TEST-OK | toolkit/mozapps/update/tests/chrome/test_9999_cleanup.xul | took 1144ms
04:03:30 INFO - ++DOMWINDOW == 212 (0x99d8e080) [pid = 11418] [serial = 693] [outer = 0x9cd9a4f0]
04:03:30 INFO - ++DOMWINDOW == 213 (0x99d8e270) [pid = 11418] [serial = 694] [outer = 0x9cd9a4f0]
04:03:30 INFO - --DOCSHELL 0x9e96a000 == 15 [pid = 11418] [id = 3]
04:03:31 INFO - ###!!! [Parent][OnMaybeDequeueOne] Error: Channel closing: too late to send/recv, messages will be lost
04:03:31 INFO - FATAL ERROR: Non-local network connections are disabled and a connection attempt to aus4.mozilla.org (63.245.217.219) was made.
04:03:31 INFO - You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests). Browser services should be disabled or redirected to a local server.
04:03:31 INFO - Hit MOZ_CRASH(Attempting to connect to non-local address!) at /builds/slave/b2g-in-lx-d-000000000000000000/build/src/netwerk/base/nsSocketTransport2.cpp:1226

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Since TH appears to be having problems commenting in the bug:
https://treeherder.mozilla.org/logviewer.html#?job_id=1323825&repo=b2g-inbound

Comment 2

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1323825
repository: b2g-inbound
start_time: 2015-02-10T03:08:38
who: rvandermeulen[at]mozilla[dot]com
machine: tst-linux32-spot-699
buildname: Ubuntu VM 12.04 b2g-inbound debug test mochitest-other
revision: bc064f894ded

FATAL ERROR: Non-local network connections are disabled and a connection attempt to aus4.mozilla.org (63.245.217.219) was made.
3416 ERROR TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/chrome/test_9999_cleanup.xul | application terminated with exit code 11
PROCESS-CRASH | toolkit/mozapps/update/tests/chrome/test_9999_cleanup.xul | application crashed [@ nsSocketTransport::InitiateSocket()]
TEST-UNEXPECTED-FAIL | leakcheck | default process: missing output line for total leaks!

Comment 3

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1328210
repository: b2g-inbound
start_time: 2015-02-10T09:21:37
who: rvandermeulen[at]mozilla[dot]com
machine: tst-linux32-spot-1026
buildname: Ubuntu VM 12.04 b2g-inbound debug test mochitest-other
revision: 03ce732e9266

FATAL ERROR: Non-local network connections are disabled and a connection attempt to aus4.mozilla.org (63.245.217.219) was made.
3408 ERROR TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/chrome/test_9999_cleanup.xul | application terminated with exit code 11
PROCESS-CRASH | toolkit/mozapps/update/tests/chrome/test_9999_cleanup.xul | application crashed [@ nsSocketTransport::InitiateSocket()]
TEST-UNEXPECTED-FAIL | leakcheck | default process: missing output line for total leaks!

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

as per irc, this specific test file exists to cleanup the other tests in this directory, so in run-by-dir mode this test is not needed at all.

While this sounds hacky it really acts as an optimization for the previous tests in the directory so we don't have to install/uninstall the same addons over and over again.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch

I think I see what is going on here and this patch should fix it. Basically, resetPrefs was called without setupPrefs being called beforehand. This removed the app.update.enabled user pref and since the app's default is true update checks would happen when the timer manager notified app update.

Comment 6

[Stephen A Pohl [:spohl]]

Comment on attachment 8562465 [details] [diff] [review]
patch

Review of attachment 8562465 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/update/tests/chrome/test_9999_cleanup.xul
@@ +43,5 @@
>    closeUpdateWindow();
> +  // Always leave the app.update.enabled and app.update.staging.enabled
> +  // preferences set to false when cleaning up.
> +  if (!Services.prefs.prefHasUserValue(PREF_APP_UPDATE_ENABLED) ||
> +      Services.prefs.getBoolPref(PREF_APP_UPDATE_ENABLED)) {

Could we just unconditionally set the PREF_APP_UPDATE_ENABLED and PREF_UPDATE_STAGING_ENABLED prefs to false, without the |if| blocks?

@@ -40,2 @@
>  
> -  resetPrefs();

Did you mean to remove resetPrefs, or did you mean to set PREF_APP_UPDATE_LOG, PREF_APP_UPDATE_ENABLED and PREF_UPDATE_STAGING_ENABLED after calling resetPrefs?

@@ +50,5 @@
>  
> +  if (!Services.prefs.prefHasUserValue(PREF_APP_UPDATE_STAGING_ENABLED) ||
> +      Services.prefs.getBoolPref(PREF_APP_UPDATE_STAGING_ENABLED)) {
> +    Services.prefs.setBoolPref(PREF_APP_UPDATE_STAGING_ENABLED, false);
> +  }

Do we need to reset the PREF_APP_UPDATE_ENABLED and PREF_UPDATE_STAGING_ENABLED prefs to their previous values at the end of this test?

Comment 7

[Robert Strong (they/them - no direct email)]

Yes.
Meant to remove.
No.

Comment 8

[Stephen A Pohl [:spohl]]

Comment on attachment 8562465 [details] [diff] [review]
patch

Review of attachment 8562465 [details] [diff] [review]:
-----------------------------------------------------------------

Cool. r+ with the removal of the two |if| blocks then. Thanks!

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: patch with comment addressed

Comment 10

[Robert Strong (they/them - no direct email)]

pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/516285b8e2d9

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/516285b8e2d9