1131771 - If dom.storage.enabled = false the site support.mozilla.org does not show pictures.

Status: RESOLVED WONTFIX

(support.mozilla.org :: General, defect, P5)

Description

[Iceberg]

Steps to reproduce:
Set in about:config dom.storage.enabled = false
Open any page of the support site support.mozilla.org
If the page contains images these are not displayed.

Actual results:
The images are not shown.

Expected results:
Images must be shown.

Comment 1

[John Hesling [:John99] (NeedInfo me)]

Also see Bug 1017850

Comment 2

[Iceberg]

Not see images causes a problem. 
Whilst it may be that the site can get better by activating the dom storage (or cookies), because the disable all images otherwise? Free nastiness. Compounded by the fact that it is a support site, must do everything to be seen, whatever the Firefox settings. 
Do not show images as default, if Firefox settings are not "pleasing", is conceptually wrong.

Comment 3

[Michael Cooper [:mythmon]]

Personally, I think that disabling this feature is not something we should support. In particular, the only way to change it is via about:config. Before entering about:config a warning is given 

"This might void your warranty!

Changing these advanced settings can be harmful to the stability, security, and performance of this application. You should only continue if you are sure of what you are doing.

[I'll be careful, I promise!]
"

I don't think we should be supporting changing these settings. If someone were to change "security.tls.version.max" in a way that broke SUMO, we would not support that user. They have opted in to a broken experience.

All that being said, localStorage is automatically disabled in private browsing mode, and I think that private browsing mode is something we *should& support. Because of this, I recommend we switch our localStorage use to the library localForage[0], which will safely deal with this instead of us constantly chasing around errors. It will be more work in the short term, but it will decrease developer work in the future.

[0]: https://github.com/mozilla/localforage

Comment 4

[Kadir Topal [:atopal]]

I can't comment on anything else, but private mode still shows pictures, we should take that into account when we prioritize.

Comment 5

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I cannot reproduce this now. Is it enough to change the "dom.storage.enabled" to "false", or are there any extra steps needed?

Comment 6

[Seburo]

Closed as per https://blog.mozilla.org/sumo/2019/06/07/sumo-platform-roadmap/