1017850 - Don't break the site (js) if localStorage isn't available

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect, P3)

Description

[Gingerbread Man]

Attachment: post_a_reply.png

Also see bug 1001284 and bug 1001283.

The correct functioning of the site is dependent on DOM storage being enabled. Among some of the weird things that happen with it disabled, the buttons at the top of the reply box are all missing, and the Sign Out link does nothing but scroll the page (it acts like a regular anchor).

It would be nice if there was a warning when DOM storage is disabled. This would benefit those who've had it disabled by an extension, disabled it at the urging of advice on the web, or simply turned it off themselves not anticipating consequences like this.

If needed, some ideas for checking if DOM storage is enabled:
http://stackoverflow.com/questions/16427636/check-if-localstorage-is-available

Comment 1

[Alice Wyman]

This just came up again.  See:

https://support.mozilla.org/forums/contributors/710809
Unable to post a new question in the support forum

Comment 2

[blue20]

Since it is possible to answer questions on the support forum without DOM storage enabled, why make it impossible to ask them without it?  It is only on https://support.mozilla.org/en-US/questions where DOM storage is needed to ask questions, but not on https://support.mozilla.org/en-US/forums/contributors.  Why?

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

We should look into this. :mythmon mentioned the real problem is that we are using localStorage without checking if it's available.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

I think it's at least 2pts to go through and fix localStorage usage.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Rehan says 1pt!

Comment 6

[Rehan Dalal (Inactive)]

Landed:
https://github.com/mozilla/kitsune/commit/b03b099e57a43717796fe0890af44ba96a7b51c8

Pushed to prod by me, right now.

Comment 7

[Alice Wyman]

This came up again today. 

https://support.mozilla.org/en-US/forums/contributors/710986 Support site not working. Unable to search for problem solution; "Ask this" button not working on FF 20.0. Question post not available

"about:config dom.storage.enabled;true solved the problem"

Comment 8

[John Hesling [:John99] (NeedInfo me)]

Problems again see discussion 
> SuMo articles: Images are not shown if "dom.storage.enabled" = false
https://support.mozilla.org/en-US/forums/contributors/711083

Further bug filed  Bug 1131771