1132129 - Server error when editing a lightweight theme with no footer

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Mathieu Agopian [:magopian]]

This follows the fixing of bug 977233.

If a theme is uploaded without a footer, editing it once it's been approved will cause a server error (http://sentry.dmz.phx1.mozilla.com/addons/addons-stage/group/24797/).

This is because the RereviewQueueTheme model wasn't modified the same way the Addon model was in https://github.com/mozilla/olympia/pull/400/files#diff-0dbefdf6fec5e745b84738831f25dcb0

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/456

Comment 2

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/63a777823308dad01da80a9a9da8292ec6386b2a


Steps to reproduce:
1/ upload a theme with only a header, no footer
2/ approve it via the editor tools
3/ go back to the theme listing, and edit it (only change the header, don't add a footer)
4/ validate that it's been correctly updated, without causing a server error.

Comment 3

[krupa raj[:krupa]]

(In reply to Mathieu Agopian [:magopian] from comment #2)
> Fixed in
> https://github.com/mozilla/olympia/commit/
> 63a777823308dad01da80a9a9da8292ec6386b2a
> 
> 
> Steps to reproduce:
> 1/ upload a theme with only a header, no footer
> 2/ approve it via the editor tools
> 3/ go back to the theme listing, and edit it (only change the header, don't
> add a footer)
> 4/ validate that it's been correctly updated, without causing a server error.

verified fixed.