Closed Bug 1132129 Opened 7 years ago Closed 7 years ago
Server error when editing a lightweight theme with no footer
This follows the fixing of bug 977233. If a theme is uploaded without a footer, editing it once it's been approved will cause a server error (http://sentry.dmz.phx1.mozilla.com/addons/addons-stage/group/24797/). This is because the RereviewQueueTheme model wasn't modified the same way the Addon model was in https://github.com/mozilla/olympia/pull/400/files#diff-0dbefdf6fec5e745b84738831f25dcb0
Fixed in https://github.com/mozilla/olympia/commit/63a777823308dad01da80a9a9da8292ec6386b2a Steps to reproduce: 1/ upload a theme with only a header, no footer 2/ approve it via the editor tools 3/ go back to the theme listing, and edit it (only change the header, don't add a footer) 4/ validate that it's been correctly updated, without causing a server error.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
(In reply to Mathieu Agopian [:magopian] from comment #2) > Fixed in > https://github.com/mozilla/olympia/commit/ > 63a777823308dad01da80a9a9da8292ec6386b2a > > > Steps to reproduce: > 1/ upload a theme with only a header, no footer > 2/ approve it via the editor tools > 3/ go back to the theme listing, and edit it (only change the header, don't > add a footer) > 4/ validate that it's been correctly updated, without causing a server error. verified fixed.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.