Closed
Bug 977233
Opened 11 years ago
Closed 10 years ago
Make footers optional on theme submission page
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
VERIFIED
FIXED
2015-01
People
(Reporter: amyt, Assigned: davidbgk)
References
Details
(Whiteboard: [ReviewTeam:P1][amy])
The add-on bar is going away with Australis, so the footer image should not be required during theme submission.
The red asterisk next to "Select a footer image for your Theme" should be removed on https://addons.mozilla.org/developers/theme/submit
Comment 1•11 years ago
|
||
We'll need to doublecheck the whole site for use of this (reviewer tools and dev tools come to mind). Amy: I think personas are loaded based off some JSON - are we just leaving the footer URL blank in cases where it doesn't exist or do we need to do something else?
Reporter | ||
Comment 2•11 years ago
|
||
Yes, leave the footer URL blank when it doesn't exist.
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Updated•11 years ago
|
Priority: -- → P4
Target Milestone: --- → 2014-04
Updated•11 years ago
|
Target Milestone: 2014-04 → 2014-06
Updated•10 years ago
|
Target Milestone: 2014-06 → 2014-07
Updated•10 years ago
|
Target Milestone: 2014-07 → 2014-08
Updated•10 years ago
|
Whiteboard: [ReviewTeam]
Updated•10 years ago
|
Target Milestone: 2014-08 → ---
Updated•10 years ago
|
Whiteboard: [ReviewTeam] → [ReviewTeam:P1]
Updated•10 years ago
|
Priority: P4 → --
Target Milestone: --- → 2014-12
Updated•10 years ago
|
Whiteboard: [ReviewTeam:P1] → [ReviewTeam:P1][amy]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → david
Assignee | ||
Comment 3•10 years ago
|
||
Fixed in https://github.com/mozilla/olympia/commit/6e84cdd17607235543b69930b6341e5a47105f3a
Note that there is an edge case not covered: you can't delete a footer once you submitted one, please declare a new bug if that's a feature that you need.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 4•10 years ago
|
||
No, I don't think that's necessary. We just don't want to force designers to put effort into designing footers that are no longer necessary. Footers that are already there can stay.
Comment 5•10 years ago
|
||
Verified as fixed in FF34(Win7) Themes can be submitted without a footer image and also the red asterisk was removed from the footer section.
Postfix screencast: http://screencast.com/t/EZFBmKIZ6a4l
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
Target Milestone: 2014-12 → 2015-01
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•