Closed Bug 1132351 Opened 6 years ago Closed 5 years ago
[Search] Loading animation loop does not disappear after all results are loaded
*Description: The loading animation loop of search app does not disappear in below two situations. a. input some characters and then all results are loaded. b. after pressing "close" button, it is empty state. *Env info Build ID 20150211162505 Gaia Revision 791e53728cd8018f1d7cf7efe06bbeb1179f0370 Gaia Date 2015-02-11 19:31:02 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/dcf030ef499d Gecko Version 37.0a2 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150211.194909 Firmware Date Wed Feb 11 19:49:19 EST 2015 Bootloader L1TC000118D0
Besides, the place of the loading loop is not in the central.
blocking-b2g: --- → 2.2?
This looks like a merge conflict resolved wrong, there are 2 loading indicators, one displays correct, the old one doesnt
Assignee: nobody → dale
Only appears on 2.2, not on master
Comment on attachment 8563288 [details] [review] [gaia] daleharvey:1132351 > mozilla-b2g:v2.2 Most of the 2.2 uplifts have hit merge conflicts, this deletion managed to survive one
https://github.com/mozilla-b2g/gaia/commit/0f98995c5890232dd01ee3d17183937caec54337 is where is got introduced, that was supposed to move it not add another
Comment on attachment 8563288 [details] [review] [gaia] daleharvey:1132351 > mozilla-b2g:v2.2 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Merge conflict [User impact] if declined: Redundant progress indicator [Testing completed]: [Risk to taking this patch] (and alternatives if risky): [String changes made]: n/a
Attachment #8563288 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
The place of loading loop is correct but the loading loop still keeps there.
Attachment #8563235 - Attachment is obsolete: true
Besides, after I click "x" button to clean the result, the loading loop does not disappear. It also happens on master.
Bug 113419 results in the loading loop keeping there after input. Then, the loop does not disappear after clearing is from Bug 1131408. Close this bug again and leave two issues to these 2 bugs.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.