1132353 - [Search] History section should not be shown when user has not visited any pages.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Hermes Cheng (inactive after July 27, 2015)]

*Description:
After I input some characters in search app and I have not visited any websites before, "HISTORY" section is shown. 

*STR:
1. have not visit any website.
2. tap rocketbar to trigger search app
3. input some characters which are included in "Mozilla Support", such as "a".

*Expected result:
No "HISTORY" section in result set.

*Actual result:
"HISTORY" section is shown with 2 pages: "Mozilla Support" and 'Mozilla"

*Env info:
Build ID               20150211162505
Gaia Revision          791e53728cd8018f1d7cf7efe06bbeb1179f0370
Gaia Date              2015-02-11 19:31:02
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/dcf030ef499d
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150211.194909
Firmware Date          Wed Feb 11 19:49:19 EST 2015
Bootloader             L1TC000118D0

Comment 1

[Hermes Cheng (inactive after July 27, 2015)]

Attachment: History Section.jpg

Comment 2

[Dale Harvey (:daleharvey)]

We insert fake history in order to show the tiles on the browser page, the fake history is inserted with a negative frecency, so we should maybe just not return those when querying for actual history

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] daleharvey:1132353 > mozilla-b2g:master

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8563262 [details] [review]
[gaia] daleharvey:1132353 > mozilla-b2g:master

Makes sense to me. Should probably have a test as well - maybe a quick unit test?

Comment 5

[Dale Harvey (:daleharvey)]

This is tricky to test, we specifically avoid loading the top sites while testing since implementing interfered with other tests. I can see if I can enable it and fix the tests that broke with it enabled. I dont think we get any value or regressions caught by unit testing this

Comment 6

[Kevin Grandon :kgrandon]

Checking the list of results from the provider when frecency < 0 is a reasonable unit test I think. For integration tests, I wonder if it's worth setting up some way to populate history/places on-demand from tests?

Comment 7

[Dale Harvey (:daleharvey)]

Updated to add a unit test, I think the best bet is to remove the hack that takes out the top sites and fix the tests, then the test build is the same as our normal one, but I think thats follow up

Comment 8

[Ben Francis [:benfrancis]]

Comment on attachment 8563262 [details] [review]
[gaia] daleharvey:1132353 > mozilla-b2g:master

Sounds good.

Comment 9

[Gregor Wagner [:gwagner]]

Not blocking

Comment 10

[Dale Harvey (:daleharvey)]

Finally green, landed in https://github.com/mozilla-b2g/gaia/commit/82f286f10a41aab84a0796c89fbefe67b179994b

Comment 11

[Hermes Cheng (inactive after July 27, 2015)]

Dale, could you please uplift to v2.2? Thanks.

Comment 12

[Dale Harvey (:daleharvey)]

Comment on attachment 8563262 [details] [review]
[gaia] daleharvey:1132353 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New Feature
[User impact] if declined: Visual regression
[Testing completed]: Automated tests added
[Risk to taking this patch] (and alternatives if risky): Little
[String changes made]: None

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/40245a826e69d3389470c85e6679ca28950639e9

Comment 14

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 and 2.2 builds.

Actual Results: History section is not shown if the user does not have a browser history.

Environmental Variables:
Device: Flame 3.0 KK (319MB) (Full Flash)
BuildID: 20150305010212
Gaia: eff3321ab4e65da3f906688ebb55ddf1e93d9452
Gecko: 56492f7244a9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2 KK (319MB) (Full Flash)
BuildID: 20150305002528
Gaia: 89af288bad6751248ff84504fa898206fee127fe
Gecko: 6d8d294aa8f3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0