1132455 - upgrade to django-rest-framework 3

Status: RESOLVED FIXED

(Input :: General, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Input has several API endpoints which are implemented in various ways, but all use django-rest-framework. At the time of this writing, we're using version 2.4.4 (bug #934979).

At the time of creating this bug, the latest version of django-rest-framework is 3.0.5. Between 2.4.4 and 3, there were a variety of non-trivial API changes in the library which are covered in some detail here:

http://www.django-rest-framework.org/topics/3.0-announcement/

This bug covers upgrading to django-rest-framework 3.0.5 (or some later version) and updating the Fjord API code accordingly.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Tossing this in the 2015q2 sprint to look into whether this blocks Django 1.8 upgrade.

For now, I'm going to make this block if only to answer the question:

   Does this block the Django 1.8 upgrade?

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

It does block the Django 1.8 upgrade. Plus it really should get done.

I've been fiddling with DRF code recently and because the DRF2 docs aren't available anymore, I keep accidentally reading DRF3 docs and I've become somewhat versed in the differences that affect Input.

Given that, I'm going to grab it and do it this week.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/580

Took a full day plus there's probably some additional work to do, so I'm making it 2 points.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Retro-actively making this a P1 since it blocked the django 1.8 upgrade and it really needed to happen.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in https://github.com/mozilla/fjord/commit/d38df032699ede6d83150614bed241de6bebc868

Going to push it out slowly now.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

I watched the Input health dashboard, incoming input, the heartbeat error log and my inbox.

I got no error email.

Heartbeat looks fine. The number of successes and errors is in line with what it's been for a while. The error log isn't showing a spat of errors.

Feedback looks fine. We're getting happy and sad requests. We're seeing the same number of API-using and non-API-using requests. Product breakdown looks ok. Platform breakdown looks ok. We continue to see email and remote-troubleshooting optins. Ratelimiting for alleviating double-submits seems fine. My dashboards are working and franklin is working, too.

I haven't heard anything about alerts, but I'm assuming it's ok or I'd have heard back by now.

Given all that, closing this out.