1133156 - Introduction of "soft" checks for HTTP framing errors broke hallmark.com, Wordpress and some other sites with CSS after gzdeflate()

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Johnny Stenback (:jst)]

The fix for bug 237623 broke http://www.hallmark.com (right before Valentines day, no less! :). The side loads, but its css file doesn't (and possibly others). Flipping the pref network.http.enforce-framing.soft to false makes the site work again.

Comment 1

[Johnny Stenback (:jst)]

[Tracking Requested - why for this release]: This regressed in 38.

Comment 2

[Johnny Stenback (:jst)]

And hat-tip to billm for tracking down the regression!

Comment 3

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/008aa6494f90

Comment 4

[Patrick McManus [:mcmanus]]

this browser thing would be a lot easier without damn web comapt.

backed out bug 237623 in comment 3 and we'll try it again.

Comment 5

[Patrick McManus [:mcmanus]]

thanks jst

Comment 6

[Philipp Wagner [:imphil]]

It also broke CSS loading for http://www.sueddeutsche.de, one of the top German news portals.

I didn't open a new bug since it's already backed out, but you may want to check this site as well before re-enabling it.

Comment 7

[Daniel Stenberg [:bagder]]

Did the backout get stuck in inbound and never got to m-c ?

Comment 8

[Emanuel Hoogeveen [:ehoogeveen]]

As of right now, yes:

https://hg.mozilla.org/integration/mozilla-inbound/log/44476ddac532/netwerk/protocol/http/nsHttpHandler.cpp
http://hg.mozilla.org/mozilla-central/log/e0cb32a0b1aa/netwerk/protocol/http/nsHttpHandler.cpp

I guess there weren't any merges over the weekend? Since the backout wasn't backed out.

Comment 9

[Patrick McManus [:mcmanus]]

(In reply to Daniel Stenberg [:bagder] from comment #7)
> Did the backout get stuck in inbound and never got to m-c ?

s/never/not yet/

looks that way https://tbpl.mozilla.org/

Comment 13

[Daniel Stenberg [:bagder]]

This problem was due to an incomplete check for the end of compressed streams in the patch for bug 237623. This has been backed out already and we're now doing the check differently.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Updating the tracking flags accordingly