Closed Bug 1133265 Opened 10 years ago Closed 10 years ago

Enable mail.tabs.drawInTitlebar by default on OSX

Categories

(Thunderbird :: Toolbars and Tabs, defect)

Product:
Thunderbird
Component:
Toolbars and Tabs
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird38 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 38.0
Tracking Flags:
Tracking Status
thunderbird38 --- fixed

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(2 files, 1 obsolete file)

Screenshot
52.87 KB, image/png
Details
drawInTitlebar.diff - v2
637 bytes, patch
Fallen
: review+
Details | Diff | Splinter Review
Thunderbird looks so much nicer on mac with this enabled. Any reason we shouldn't do this for tb38?
OS: Mac OS X → All
Hardware: x86 → All
Version: 30 → Trunk
This only applies to Mac. Windows and Linux have the pref enabled already.
OS: All → Mac OS X
Attached patch drawInTitlebar.diff (obsolete) — — Splinter Review
This was done in bug 941740. It actually looks good now, so I think we can just do it.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8564680 - Flags: review?(josiah)
Attached image Screenshot —
Comment on attachment 8564680 [details] [diff] [review] drawInTitlebar.diff As Linux doesn't support yet draw into titlebar it would be better to do this like Firefox: https://dxr.mozilla.org/comm-central/source/mozilla/browser/app/profile/firefox.js#451 to not enable it without needed code when it's possible.
Comment on attachment 8564680 [details] [diff] [review] drawInTitlebar.diff Review of attachment 8564680 [details] [diff] [review]: ----------------------------------------------------------------- Looks good if you apply Paenglab's feedback. There was a reason we were waiting to enable this, but I don't think we need to wait any longer. Thanks for writing the patch!
Attachment #8564680 - Flags: review?(josiah) → review+
Summary: Enable mail.tabs.drawInTitlebar by default → Enable mail.tabs.drawInTitlebar by default on OSX
Hmm ok, I've done as you asked. But looking at the diff, we had it enabled by default on Linux before, right? We only had it disabled for mac? This patch would be disabling it for Linux and enabling it for mac.
Attachment #8564680 - Attachment is obsolete: true
Flags: needinfo?(richard.marti)
Attachment #8566828 - Flags: review+
I think it's a no-op on Linux, so it doesn't really matter.
Yes, Linux doesn't support drawInTitlebar yet and it doesn't matter. But when it's support it it's better to disable it until everything is fixed.
Flags: needinfo?(richard.marti)
Ok, as you wish. Setting checkin-needed for the updated patch that disables it on linux and enables it on mac.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 38.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: