1133429 - [ReadingList] Store page metadata when adding current tab to the ReadingList

Status: RESOLVED FIXED

(Firefox Graveyard :: Reading List, defect, P1)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

This ties in to bug 1123519 and bug 1131457, which ideally would call an API that takes a reference to a tab (or <browser>, I guess) as a param. 

We need that API built. It would:
* Get metadata via whatever bug 1131911 provides
* Normalize it (ie, we only want certain metadata field, only one image, etc)
* Add it to the DB


The UI at the moment requires:
* Title
* Image
* Favicon (somewhat already handled by favicon service)

Additional data we'll likely want in the future:
* Excerpt/description
* Keywords

And data we may want, but are less clear about:
* Author
* Publication date

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Blair McBride [:Unfocused] (I don't read bugmail - needinfo? me!) from comment #0)
> * Favicon (somewhat already handled by favicon service)

For clarification: Favicon was included here for completeness, and shouldn't be handled by this bug. Favicon service handle this (but see also bug 1089559 and bug 573638).

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

And this of course relies on the storage backend.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Mass change of ReadingList bugs, moving to their own component. Filter bugspam on the following quote:

“Reading is to the mind what exercise is to the body.”
― Joseph Addison

Comment 4

[Justin Dolske [:Dolske]]

Shifting over to Jared.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

From rnewman, we'll need to change this from `image` to `preview`.

https://github.com/mozilla-services/readinglist/issues/156

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8580154 [details] [diff] [review]
Patch

Review of attachment 8580154 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the field name change

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for check-in

With field renamed and DB name revv'd so other devs won't break since the schema changed.

Comment 9

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/ad7b242dfaf7

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad7b242dfaf7

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7ed35febcb50