1133499 - Undo closed tab is broken

Status: RESOLVED DUPLICATE of bug 1134015

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Nexus 5 (Android 5.0.1)
Build: Firefox for Android 38.0a2 (2015-02-15)
Steps to reproduce:
1. Open a tab and load gmail.com
2. Close the tab opened at step 1 by swiping it or by tapping on X button
3. Tap 'Undo' on the  'Closed tab - Undo' tab toast notification

Expected results:
- The closed tab is opened in the same position as it was before.

Actual results:
- Nothing happens

Note:
- This is a recent regression:
1.mozilla-central:
good build: 13-02
bad build: 14-02
pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2f5c5ec1a24b&tochange=a7c177546ca0
2. inbound:
good build: 1423821902
bad build: 1423848417
pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=848ee095492d&tochange=af230f02ff2a

Comment 1

[Teodora Vermesan (:TeoVermesan)]

fx-team:
good build: 1423783651
bad build: 1423783652
puhslog: http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=f85b33641ef7&tochange=0b63903a6f41

Bug 1099500 - Potential memory leak in browser.js due to faulty toast notification handling ?

Also, when installing an add-on, tapping "ADD-ONS" from Installation complete" notification does nothing.

Comment 2

[Aaron Train [:aaronmt]]

Same regression that caused bug 1133278?

Comment 3

[Aaron Train [:aaronmt]]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #1)
 > Also, when installing an add-on, tapping "ADD-ONS" from Installation
> complete" notification does nothing.

I think the code change broke super toast interactions all-together.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #3)
> (In reply to Teodora Vermesan (:TeoVermesan) from comment #1)
>  > Also, when installing an add-on, tapping "ADD-ONS" from Installation
> > complete" notification does nothing.
> 
> I think the code change broke super toast interactions all-together.

Yeah, I bet it's the same cause as bug 1133278

Comment 6

[Aaron Train [:aaronmt]]

Should be fixed via bug 1134015