1134015 - The button toasts are broken

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Andy Pusch [:AndyP]]

This is a regression of bug #1099500.

Depends on bug #1133278 and bug #1133499.

Comment 1

[Aaron Train [:aaronmt]]

There is a patch up in 1099500, but we don't need another dupe.

Comment 2

[Aaron Train [:aaronmt]]

Whoops, read Margaret's last comment.

Comment 3

[Andy Pusch [:AndyP]]

Attachment: bug1134015_fixBrokenButtonToast.diff

ButtonToast.java hides the toast in its onClickListener using ReasonHidden.CLICKED therefore it is neccessary to not delete the callbacks here if this reason occurs.

Comment 4

[Andy Pusch [:AndyP]]

Just some additional information:
The callback data in case of ReasonHidden.CLICKED is removed in ButtonToast.java [1], there is also ReasonHidden.STARTUP which is as well used in ButtonToast.java. Both cases are now excluded.

[1] https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/ButtonToast.java#122

Comment 5

[:Margaret Leibovic]

Comment on attachment 8565694 [details] [diff] [review]
bug1134015_fixBrokenButtonToast.diff

Review of attachment 8565694 [details] [diff] [review]:
-----------------------------------------------------------------

I can land this for you.

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/15edc0cdbae7

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/15edc0cdbae7

Comment 8

[Teodora Vermesan (:TeoVermesan)]

-Close a tab, tap 'Undo' on the 'Closed tab - Undo' tab toast notification => The closed tab is opened in the same position as it was before.
-Choose "Open Link in New Tab/Private Tab", tap "Switch" on the "New Tab opened" notification => The new tab is displayed. So:
Verified as fixed on:
Device: Nexus 5 (Android 5.0.1)
Build: Firefox for Android 38.0a1 (2015-02-19)