1133662 - [ReadingList] Show something useful in the sidebar when the Reading List is empty

Status: VERIFIED FIXED

(Firefox Graveyard :: Reading List, defect, P3)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

If all items in the ReadingList have been removed, showing a blank sidebar may make it feel broken. Ideally we'd show some message, maybe an encouragement to add items or something like that.

See also bug 1124400 comment 9, and related comments.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Michael: Thoughts on this? 

(If we want this for v1, we need to know the strings for it as soon as possible.)

Comment 2

[Michael Maslaney [:mmaslaney] ([e-mail])]

What do we currently display for an empty bookmarks side panel?  It would be great if we could provide a Reading List tip like "Click on the (+) icon in the URL bar for quick adding", or something similar.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Michael Maslaney [:mmaslaney] ([e-mail]) from comment #2)
> What do we currently display for an empty bookmarks side panel?

Nothing. But AFAIK it's not possible to get into that state anyway (due to standard folders that can't be removed). With history it's possible, but we just show nothing there: http://d.pr/i/15MuV

With ReadingList, it's going to be a lot more common to have an empty list.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

just to note that bug 1132988 is going to provide SUMO articles as default links for the reading list so the reading lists won't be empty to start.  That FTU work is being tracked in bug 1132951

Comment 5

[Michael Maslaney [:mmaslaney] ([e-mail])]

Matej, could you review the copy for the empty Reading List sidebar? Feel free to improve on the current proposal.

http://d.pr/i/1eSvw

Comment 6

[Matej Novak [:matej]]

(In reply to Michael Maslaney [:mmaslaney] ([e-mail]) from comment #5)
> Matej, could you review the copy for the empty Reading List sidebar? Feel
> free to improve on the current proposal.
> 
> http://d.pr/i/1eSvw

Would this be too long?

"Add articles to your Reading List to save them for later and find them easily when you need them."

If so, here's a shorter option:

"Add articles to your Reading List to save them for later."

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Matej Novak [:matej] from comment #6)
> "Add articles to your Reading List to save them for later and find them
> easily when you need them."

http://d.pr/i/1fySI

> "Add articles to your Reading List to save them for later."

http://d.pr/i/14qj1

I think the longer one fits in fine - what do you think, Michael?

Comment 8

[Matej Novak [:matej]]

(In reply to Blair McBride [:Unfocused] (I don't read bugmail - needinfo? me!) from comment #7)
> (In reply to Matej Novak [:matej] from comment #6)
> > "Add articles to your Reading List to save them for later and find them
> > easily when you need them."
> 
> http://d.pr/i/1fySI
> 
> > "Add articles to your Reading List to save them for later."
> 
> http://d.pr/i/14qj1
> 
> I think the longer one fits in fine - what do you think, Michael?

I think so, too, and it feels a little friendlier. That would be my vote. Thanks.

Comment 9

[Michael Maslaney [:mmaslaney] ([e-mail])]

(In reply to Blair McBride [:Unfocused] (I don't read bugmail - needinfo? me!) from comment #7)
> (In reply to Matej Novak [:matej] from comment #6)
> > "Add articles to your Reading List to save them for later and find them
> > easily when you need them."
> 
> http://d.pr/i/1fySI
> 
> > "Add articles to your Reading List to save them for later."
> 
> http://d.pr/i/14qj1
> 
> I think the longer one fits in fine - what do you think, Michael?

• +1 for the longer/friendlier version

Comment 10

[Marco Mucci [:MarcoM]]

Not required for Reading List V1 Campaign Release.

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Mass change of ReadingList bugs, moving to their own component. Filter bugspam on the following quote:

“Reading is to the mind what exercise is to the body.”
― Joseph Addison

Comment 12

[Justin Dolske [:Dolske]]

Nominally P4 polish, but as it feels like broken UI let's call this P3.

Comment 13

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Easy peasy.

Comment 14

[Florian Quèze [:florian]]

Comment on attachment 8579741 [details] [diff] [review]
Patch v.1

Review of attachment 8579741 [details] [diff] [review]:
-----------------------------------------------------------------

I renamed the sidebar.css file to sidebar.css.inc in bug 1123525, so this patch won't apply.

All the mockups linked in this bug have the placeholder text centered, I don't see anything in this patch centering the text; is this intentional?

Comment 15

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

Merged to tip of fx-team.

Comment 16

[Florian Quèze [:florian]]

Comment on attachment 8579758 [details] [diff] [review]
Patch v.2

Review of attachment 8579758 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good :-)

::: browser/themes/shared/readinglist/sidebar.inc.css
@@ +17,5 @@
>  }
>  
> +#emptyListInfo {
> +  padding: 3em 1em;
> +  text-align: center;

Let's add a |  cursor: default;| in here.

Comment 17

[Justin Dolske [:Dolske]]

Fixed and pushed. https://hg.mozilla.org/integration/fx-team/rev/bb305274f262

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bb305274f262

Comment 19

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 39.0a1 (2015-03-20) using Ubuntu 14.04 (x64), Windows 7 (x64) and Mac OS X 10.9.5.

Please note that this is still affected by Bug 1137089, so the "Add articles to your Reading List to save them for later and [...]" text and its background are not adapting properly to high-contrast and Developer Edition themes.

Comment 20

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e967dc8f6f3e

Comment 21

[Andrei Vaida [:avaida]]

Verified fixed Aurora 38.0a2 (2015-03-29) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.