Closed Bug 1134292 Opened 10 years ago Closed 9 years ago

Batch message ACKs

Categories

(Core :: DOM: Push Subscriptions, defect)

Product:
Core
Component:
DOM: Push Subscriptions
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: lina, Unassigned)

References

Details

The client currently processes notifications one at a time, and sends individual ACKs for each. Unfortunately, the Simple Push server flushes all pending notifications in response to each ACK, meaning it will redeliver notifications that the client is already processing. This creates a lot of chatter if there are several outstanding notifications (e.g., server sends 6 notifications, client queues them for processing and acknowledges 1, server sends the 5 unacknowledged notifications, client queues the 5 for processing, and so on). Processing and acknowledging notifications in batches will also reduce the number of calls to `ppmm.broadcastAsyncMessage` for the Desktop API.
We can also change the server to batch and flush pending notifications periodically, but :nsm already mentioned batching ACKs as a FIXME: https://github.com/mozilla/gecko-dev/blob/master/dom/push/PushService.jsm#L1083
Status: NEW → ASSIGNED
Assignee: kcambridge → nobody
Status: ASSIGNED → NEW
No longer needed with Web Push-style delivery. Acking messages immediately prevents re-transmission on reconnect.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.