1134542 - Drop nsIDOMWindowUtils.sendKeyEvent()

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

We need Bug 1137557 to move forms.js away from this method.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=749c10b47bf9252996c7b5b188077cfdd5428c72

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1134542 - Get rid of nsIDOMWindowUtils::sendKeyEvent() and nsIFrameLoader::sendCrossProcessKeyEvent()

nsIDOMWindowUtils::sendKeyEvent() is already replaced with nsITextInputProcessor
for making callers set any attributes of KeyboardEvent and guaranteeing
consistency behavior with keyboard events caused by native key events.  E.g.,
whether keypress event should be dispatched or not is automatically decided.

nsIFrameLoader::sendCrossProcessKeyEvent() is similart to
nsIDOMWindowUtils::sendKeyEvent() but it dispatches keyboard events in
child process directly.  Currently, nsITextInputProcessor doesn't have this
feature but nobody wants/uses this feature.  So, for removing actual
implementation of nsIDOMWindowUtils::sendKeyEvent(), i.e.,
nsContentUtils::SendKeyEvent(), which is shared by both
nsDOMWindowUtils::SendKeyEvent() and nsFrameLoader::SendCrossProcessKeyEvent(),
we should remove this unused API too. (FYI: it's implemented for old Fennec,
by bug 553149.)

Review commit: https://reviewboard.mozilla.org/r/217086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217086/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

FYI: I wait bug 1433648 and bug 1434317 because I don't want to break Thunderbird. However, I'd like to land this ASAP and the fix is really easy. So, even if they are not fixed in the next week, I'll land this anyway.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Posted to dev-platform, firefox-dev and maildev:
https://groups.google.com/forum/#!topic/mozilla.dev.platform/SD2-nXTuGGA

Comment 6

[Olli Pettay [:smaug]]

Comment on attachment 8947348 [details]
Bug 1134542 - Get rid of nsIDOMWindowUtils::sendKeyEvent() and nsIFrameLoader::sendCrossProcessKeyEvent()

https://reviewboard.mozilla.org/r/217086/#review222924

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d823fb9ade6c5e561ffe43690beb8bf6a6a8d4f7

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8947348 [details]
Bug 1134542 - Get rid of nsIDOMWindowUtils::sendKeyEvent() and nsIFrameLoader::sendCrossProcessKeyEvent()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217086/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/158bcad6b96a
Get rid of nsIDOMWindowUtils::sendKeyEvent() and nsIFrameLoader::sendCrossProcessKeyEvent() r=smaug

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/158bcad6b96a

Comment 11

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/158bcad6b96a

Comment 13

[Chris Mills (Mozilla, MDN editor) [:cmills]]

Sorry, but the MDN team no longer has time/resources to update XPCOM docs. We are focusing just on web platform docs going forward.