Closed Bug 1434317 Opened 2 years ago Closed 2 years ago
Instant Messaging of Thunderbird should stop using ns
IDOMWindow Utils .send Key Event()
Instant Messaging of Thunderbird still uses nsIDOMWindowUtils.sendKeyEvent() which was marked obsolete for several years ago: https://searchfox.org/comm-central/source/im/content/conversation.xml#1055 https://searchfox.org/comm-central/source/im/content/tabbrowser.xml#318 https://searchfox.org/comm-central/source/mail/components/im/content/imconv.xml#259 https://searchfox.org/comm-central/source/mail/components/im/content/imconversation.xml#976 This will be removed completely (if it's possible, at 60). So, please rewrite them with nsITextInputProcessor ASAP. EventUtils.js must be a good reference to use it: https://searchfox.org/mozilla-central/rev/97cb0aa64ae51adcabff76fb3b5eb18368f5f8ab/testing/mochitest/tests/SimpleTest/EventUtils.js#835-905 https://searchfox.org/mozilla-central/rev/97cb0aa64ae51adcabff76fb3b5eb18368f5f8ab/testing/mochitest/tests/SimpleTest/EventUtils.js#1248-1269
FYI: Even if this bug won't be fixed by next weekend, I'll get rid of the legacy API on 12th Feb.
Martin, maybe you could look into it?
Or Aceman ;-)
Yeah, maybe. Do we need to care for the /im/ files or are those dead?
Flags: needinfo?(acelists) → needinfo?(florian)
(In reply to :aceman from comment #4) > Yeah, maybe. Do we need to care for the /im/ files or are those dead? Dead enough that we don't need to fix it there.
As of yesterday, IB won't build any more, see bug 1434515 comment #7.
I never know if that /im directory contains the chat backend and mail/components/im is some glue to make chat work in TB. Or if /im is glue to make a standalone Instantbird. It would be useful to remove (or mark) unneeded files.
im/ is the Instantbird UI mail/components/im is the Thunderbird Chat UI chat/ is the chat back-end, shared between Instantbird and Thunderbird (like mailnews is shared between TB and SeaMonkey). We'll remove im/ at some point (bug 1410739), but while we still have some features working in Instantbird and not ported to Thunderbird chat yet, it's still nice to be able to find the code in searchfox.
OK, so chat/ is the backend, thanks.
Assignee: nobody → martin
Status: NEW → ASSIGNED
Simplest solution: just dispatch DOM events on the input field instead of doing fancy other stuff that doesn't work.
Attachment #8948064 - Flags: review?(florian)
Comment on attachment 8948064 [details] [diff] [review] bug1434317.patch Review of attachment 8948064 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. I would never arrive at this because I don't really know what the IM code tries to do.
Thanks from me, too :-)
Reminder: I'll drop the API on the next Monday or Tuesday.
Thanks, we're aware of it. Florian, can you please review the patch.
Comment on attachment 8948064 [details] [diff] [review] bug1434317.patch Looks good and works well, thanks!
Attachment #8948064 - Flags: review?(florian) → review+
Thanks, I'll land this tonight.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/b0c82d15482c Use DOM event dispatching to replace nsIDOMWindowUtils.sendKeyEvent(). r=florian
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.