enable the vertical writing-mode reftest directory

RESOLVED FIXED in Firefox 39

Status

()

Core
Layout
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

(Blocks: 1 bug)

unspecified
mozilla38
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We don't need to wait for the pref to be flipped by default; now that we're building with vertical mode enabled in the code, we can just set the pref from within the reftest manifest, and begin running these tests regularly.
(Assignee)

Comment 1

3 years ago
Created attachment 8566485 [details] [diff] [review]
Enable the vertical writing-mode reftest directory
Attachment #8566485 - Flags: review?(smontagu)
(Assignee)

Updated

3 years ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Try run with this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a51d32b80d2b. I'm expecting 1131013-vertical-bidi.html to fail here, as it needs the followup patch (bug 1131013 comment 7) to work across all platforms.
Depends on: 1131013
Attachment #8566485 - Flags: review?(smontagu) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/338cb106bfc4 - you'll be wanting to spend rather a lot of time on try with debug builds, since at the very least ua-style-sheet-input-number-1.html has between zero and sixteen "Shouldn't be incomplete if availableBSize is UNCONSTRAINED" assertion failures.
(Assignee)

Comment 5

3 years ago
Oh, drat. That's thanks to bug 1123299, which is also why that test was already marked as known-failing. I've disabled the offending part of the test for the time being (as we've also done in some other comparable cases), and will add a comment in bug 1123299 to remind us to restore it once it's implemented.

Re-landed without that problem, I trust:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e37d57033b13
sorry had to back this out for breaking reftests like https://treeherder.mozilla.org/logviewer.html#?job_id=6874976&repo=mozilla-inbound
(Assignee)

Comment 7

3 years ago
Ugh - sorry about that. :( Filed bug 1135622 for the unexpected failure, and restored the failure annotation that we had in the original landing (the one that was backed out for assertions).

Tryserver says we should be ok now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa27c631c2e7 (the failures there are a new test that's not actually present in the tree, or in this landing).

So here we go again:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45d4cc092de1
(Assignee)

Updated

3 years ago
Depends on: 1139646
https://hg.mozilla.org/mozilla-central/rev/2bef1523a906
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.