Closed Bug 1135152 Opened 5 years ago Closed 5 years ago

Report Abuse button is styled inconsistently

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Avenir
defect

Tracking

(Not tracked)

VERIFIED FIXED
2015-03-24

People

(Reporter: cvan, Assigned: kngo)

References

()

Details

(Whiteboard: [ktlo])

Load https://marketplace.firefox.com/app/zirma

Mobile:
https://www.dropbox.com/s/bi1pa80qlqlzjra/Screenshot%202015-02-20%2010.15.34.png?dl=0

Should at least be the same style/width as that of the "Rating Details" button.

Desktop:
https://www.dropbox.com/s/3aoxmzioxhkdddt/Screenshot%202015-02-20%2010.16.40.png?dl=0

It is centred and all alone by itself, which looks awkwrd.
Priority: -- → P3
Blocks: 1135257
wrong width since fixed. it's still alone, but that's the design
Assignee: nobody → kngo
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
When was this fixed?

On -dev, I can still reproduce it:

https://marketplace-dev.allizom.org/app/zirma

https://www.dropbox.com/s/8j1xem151hjtnth/Screenshot%202015-03-13%2014.34.29.png?dl=0

Also, why did you mark this `[qa-]`?
Technically speaking, this is the design, so it should be a wontfix.

However, andym agreed that it looks awkward. So I will NI pwalm.
Flags: needinfo?(pwalmsley)
Ah, I only tried reproducing on 320px. The rating button stretches.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to David Durst [:ddurst] from comment #3)
> Technically speaking, this is the design, so it should be a wontfix.
> 
> However, andym agreed that it looks awkward. So I will NI pwalm.

I filed this for two issues:

1. The inconsistent width (implementation issue).
2. The awkward centered positoning (design issue).

Neither is fixed. Kevin thought he fixed #1 - but was mistaken.
No longer blocks: 1135257
Blocks: 1135257
Made the button 100% width on mobile like all the other cool kids

https://github.com/mozilla/fireplace/commit/b7999327ba46fa1377aa9db3b183262c14751457
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → 2015-03-24
The button looks ok on mobile width: http://screencast.com/t/JAk7UXsTu
Will wait for pwalm opinion on the second issue before closing this bug.
Flags: needinfo?(pwalmsley)
Whiteboard: [ktlo]
So can we close this? :pwalm what's your opinion on 2. The awkward centered positoning (design issue). from comment 5.
Flags: needinfo?(pwalmsley)
Looks good on my end, we can close this. Thanks guys.
Flags: needinfo?(pwalmsley)
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.