1135152 - Report Abuse button is styled inconsistently

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

Load https://marketplace.firefox.com/app/zirma

Mobile:
https://www.dropbox.com/s/bi1pa80qlqlzjra/Screenshot%202015-02-20%2010.15.34.png?dl=0

Should at least be the same style/width as that of the "Rating Details" button.

Desktop:
https://www.dropbox.com/s/3aoxmzioxhkdddt/Screenshot%202015-02-20%2010.16.40.png?dl=0

It is centred and all alone by itself, which looks awkwrd.

Comment 1

[Kevin Ngo [:ngoke]]

wrong width since fixed. it's still alone, but that's the design

Comment 2

[Christopher Van Wiemeersch [:cvan]]

When was this fixed?

On -dev, I can still reproduce it:

https://marketplace-dev.allizom.org/app/zirma

https://www.dropbox.com/s/8j1xem151hjtnth/Screenshot%202015-03-13%2014.34.29.png?dl=0

Also, why did you mark this `[qa-]`?

Comment 3

[David Durst [:ddurst]]

Technically speaking, this is the design, so it should be a wontfix.

However, andym agreed that it looks awkward. So I will NI pwalm.

Comment 4

[Kevin Ngo [:ngoke]]

Ah, I only tried reproducing on 320px. The rating button stretches.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to David Durst [:ddurst] from comment #3)
> Technically speaking, this is the design, so it should be a wontfix.
> 
> However, andym agreed that it looks awkward. So I will NI pwalm.

I filed this for two issues:

1. The inconsistent width (implementation issue).
2. The awkward centered positoning (design issue).

Neither is fixed. Kevin thought he fixed #1 - but was mistaken.

Comment 6

[Kevin Ngo [:ngoke]]

Made the button 100% width on mobile like all the other cool kids

https://github.com/mozilla/fireplace/commit/b7999327ba46fa1377aa9db3b183262c14751457

Comment 7

[Madalin Cotetiu]

The button looks ok on mobile width: http://screencast.com/t/JAk7UXsTu
Will wait for pwalm opinion on the second issue before closing this bug.

Comment 8

[Madalin Cotetiu]

So can we close this? :pwalm what's your opinion on 2. The awkward centered positoning (design issue). from comment 5.

Comment 9

[Philip [:pwalm]]

Looks good on my end, we can close this. Thanks guys.

Comment 10

[Madalin Cotetiu]

Closing bug.