1135164 - display a warning on show_bug when an unassigned bug has a patch attached

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Josh Matthews [:jdm]]

We have successfully created a culture where people are happy to teach new bugzilla users about tools like checkin-needed that will help them get their patches checked in. That's great! Comments like https://bugzilla.mozilla.org/show_bug.cgi?id=1133846#c12 make me really happy. Unfortunately, we do not have widespread understanding of the difference that editbugs makes for an account, such that we repeatedly tell new users to perform actions that they are unable to do. We really need to find some way around this problem that doesn't require teaching all members of the mozilla community about editbugs.

Comment 1

[:glob ✱]

(In reply to Josh Matthews [:jdm] from comment #0)
> We have successfully created a culture where people are happy to teach new
> bugzilla users about tools like checkin-needed that will help them get their
> patches checked in. That's great! Comments like
> https://bugzilla.mozilla.org/show_bug.cgi?id=1133846#c12 make me really
> happy. Unfortunately, we do not have widespread understanding of the
> difference that editbugs makes for an account, such that we repeatedly tell
> new users to perform actions that they are unable to do. We really need to
> find some way around this problem that doesn't require teaching all members
> of the mozilla community about editbugs.

the bug's assignee always has the ability to edit that bug.  however bug 1133846 is still assigned to nobody, and that's the reason for the breakdown there.

i suspect this is really an issue of not assigning the bug to the person doing the work, rather than an issue with the visibility of editbugs permissions.  we could add a warning on show_bug when there are patches against an unassigned bug.

do you have any other examples?

Comment 2

[Josh Matthews [:jdm]]

All of my other examples come from IRC or just bugmail that I can't be bothered to search for right now. It's nice to know that assignees can modify all parts of a bug, but I don't think that's good enough. We have a culture of not caring about the assignee field, and we have tools that go and set the assignee after commits are made for this very reason. In particular, when it comes to new contributors, we encourage not setting the assignee until after a patch is made; in practice this means that assignees are not set at all.

Comment 3

[:glob ✱]

i had a quick chat with jdm over irc; he's ok with morphing this bug so we display some sort of warning when an unassigned bug has a patch attached.

- we should only display this warning to users with editbugs
- the warning should probably be displayed next to the patch in the attachment table

Comment 4

[:glob ✱]

Attachment: 1135164_1.patch

- adds a warning under the attachments table

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8608122 [details] [diff] [review]
1135164_1.patch

Review of attachment 8608122 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

I think there might be some value in having hover text (or a link) explaining why there is a warning for unassigned bugs with patches.

Comment 6

[:glob ✱]

(In reply to Dylan William Hardison [:dylan] from comment #5)
> I think there might be some value in having hover text (or a link)
> explaining why there is a warning for unassigned bugs with patches.

given this warning is only displayed to users with editbugs (ie. users who we trust to know how bugzilla works), i'm not sure this is necessary.

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   b09be15..0677733  master -> master