113554 - Copy and Paste a bookmark folder into itself cause endless nested folders, sometimes crash.

Status: RESOLVED DUPLICATE of bug 97424

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[Jessie Li]

Build ID:2001112009

1.Select Bookmarks|Manage Bookmarks.
2.Select a folder.
3.Select Edit|Copy.
4.Select any item in this folder.
5.Select Edit|Paste.

Actual Results:Pasting a folder into itself can be allowed.

Expected Results:Pasting a folder into itself should not be allowed.

Comment 1

[Chris Lyon]

Related to Bug 97424?

Comment 2

[Jessie Li]

Maybe it is related to Bug 97424,but the problem is different.
Bug 113554 says:"the operation of pasting should not be done."

Comment 3

[Colin Blake]

*** Bug 114428 has been marked as a duplicate of this bug. ***

Comment 4

[Jay Farrell]

While doing the "Front-end" testing, specificly the "Bookmarks" test "Self-Drop"
you can copy a folder into another folder. I was going mention this is 114428,
but it seems that was a dup for this. (Sorry about the dup entry)

Comment 5

[Asa Dotzler [:asa]]

->default assignee.

Comment 6

[Chris Lyon]

*** Bug 123275 has been marked as a duplicate of this bug. ***

Comment 7

[Bolian Yin]

Attachment: forbid copying a folder onto itself

We can simply forbid such operation.  I have tested on my machine.  Please
review it.

Comment 8

[Pierre Chanial]

adding pach and review keywords.
but Bolian, you should E-mail the reviewers.

Comment 9

[Pierre Chanial]

*** Bug 116823 has been marked as a duplicate of this bug. ***

Comment 10

[Jay Farrell]

I could not drop a folder onto itself with the 20020419 release of OpenVMS.
Unfortunatly, I couldn't drop a sub-folder onto another folder at ALL.
I loose the sub folder completely!!! (Drag a sub-folder onto any folder
and you loose the sub-folder).

Comment 11

[Jay Farrell]

Just wanted to add that I did reproduce this on Linux 2002041711,
but not all them time! Sometime dropping a sub folder into another
folder works, and sometimes it doesn't. After further testing on OpenVMS,
I was not able to always reproduce the problem, but the problem still
exists.

Comment 12

[Bolian Yin]

The bug does not exist in RC2 now, bug I do not know which bug fix this?
ben, can we close it?

Comment 13

[Bolian Yin]

This bug is still there and become more severe. 
Copy and Paste a bookmark folder into itself cause endless nested folders, and
sometimes Mozilla Crash.

Comment 14

[Bolian Yin]

==> Bolian

Comment 15

[Bolian Yin]

Attachment: patch: avoid endless nesting

need r=

Comment 16

[Henry Jia]

Comment on attachment 92861 [details] [diff] [review]
patch: avoid endless nesting 

Seems good. Thx, Bolian.

r=henry

Comment 17

[Bolian Yin]

*** This bug has been marked as a duplicate of 97424 ***