1135825 - RTCIdentityProviderRegistrar.h:34:21: error: 'WrapObject' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

New clang build warning, for recent clang (3.6 & 3.7):
{
 4:15.13 In file included from /scratch/work/builds/mozilla-inbound/obj/dom/bindings/UnifiedBindings13.cpp:266:
 4:15.13 In file included from ./RTCIdentityProviderBinding.cpp:12:
 4:15.13 ../../dist/include/mozilla/dom/RTCIdentityProviderRegistrar.h:34:21: error: 'WrapObject' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
 4:15.13   virtual JSObject* WrapObject(JSContext* aCx);
 4:15.13                     ^
 4:15.13 /scratch/work/builds/mozilla-inbound/mozilla/dom/base/nsWrapperCache.h:155:21: note: overridden virtual function is here
 4:15.13   virtual JSObject* WrapObject(JSContext* cx) = 0;
 4:15.13                     ^
 4:16.08 UnifiedBindings16.o
}

Looks like this .h file was added over the weekend, in bug 975144 --> setting as blocking that bug.

Comment 1

[Daniel Holbert [:dholbert]]

(I'm gonna land a fix with the blanket r+ that ehsan granted me for fixes of this sort over on bug bug 1126447,.)

Comment 2

[Daniel Holbert [:dholbert]]

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/a55ca32e464f

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a55ca32e464f