Closed
Bug 1135825
Opened 9 years ago
Closed 9 years ago
RTCIdentityProviderRegistrar.h:34:21: error: 'WrapObject' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
New clang build warning, for recent clang (3.6 & 3.7): { 4:15.13 In file included from /scratch/work/builds/mozilla-inbound/obj/dom/bindings/UnifiedBindings13.cpp:266: 4:15.13 In file included from ./RTCIdentityProviderBinding.cpp:12: 4:15.13 ../../dist/include/mozilla/dom/RTCIdentityProviderRegistrar.h:34:21: error: 'WrapObject' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] 4:15.13 virtual JSObject* WrapObject(JSContext* aCx); 4:15.13 ^ 4:15.13 /scratch/work/builds/mozilla-inbound/mozilla/dom/base/nsWrapperCache.h:155:21: note: overridden virtual function is here 4:15.13 virtual JSObject* WrapObject(JSContext* cx) = 0; 4:15.13 ^ 4:16.08 UnifiedBindings16.o } Looks like this .h file was added over the weekend, in bug 975144 --> setting as blocking that bug.
Assignee | ||
Comment 1•9 years ago
|
||
(I'm gonna land a fix with the blanket r+ that ehsan granted me for fixes of this sort over on bug bug 1126447,.)
Assignee | ||
Comment 2•9 years ago
|
||
Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/a55ca32e464f
Flags: in-testsuite-
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a55ca32e464f
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•