1136346 - [Settings][Privacy Controls] 'Custom location' header is not consistent with other header capitalization; location is not capitalized.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Joshua Mitchell (Inactive)]

Attachment: negative.png

Description:
Inconsistent capitalization of header. All other headers seem to capitalize the first letter of each word. 

Repro Steps:
1) Update a Flame to 20150224010314
2) Launch Settings
3) Navigate to Settings > Privacy Controls > Location Accuracy > Custom location

Actual:
The l in location is not capitalized 

Expected:
Consistent Capitalization 

Environmental Variables:
Device: Flame Master
Build ID: 20150224010314
Gaia: 31ac1cd7a029d5e46dd7c92537b5c973c5d9826e
Gecko: 368c62292249
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 100%
See attached: Screenshot

Comment 1

[Joshua Mitchell (Inactive)]

This issue also occurs in 2.2  (Privacy Controls not present prior to 2.2)

Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150224002637
Gaia: 8e98fe665f3821d10d4d982cbb14cbe5b94d0be5
Gecko: 2b70d9d62799
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision and assignment.

Comment 3

[Gerry Chang [:gchang]]

Hi Marta,
Can you help on this?

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] martasect:Bug_1136346 > mozilla-b2g:master

Comment 5

[marta]

patch proposed. Asking :PBylenga for a review.

Comment 6

[Théo Chevalier]

In this specific case it's safe to keep the same entity name and only update the string — that's en-US only typography, localizers follow their own rules for capitalization so locales are already fixed and don't need to be notified of the change. (More info on https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings)

So the patch can just be:

-custom-location-ala-10 = Custom location
+custom-location-ala-10 = Custom Location

If you're updating to patch as above, you can remove late-l10n keyword from this bug.

Comment 7

[Peter Bylenga [:PBylenga]]

Comment on attachment 8570727 [details] [review]
[gaia] martasect:Bug_1136346 > mozilla-b2g:master

Theo can you or a peer handle this review?

Comment 8

[Théo Chevalier]

Comment on attachment 8570727 [details] [review]
[gaia] martasect:Bug_1136346 > mozilla-b2g:master

I can't give an official review (not a peer), even if given the patch I assume it would be okay. But autolander won't land the patch anyway, so asking Evelyn :)

The patch looks good to me. Since we're in "soft string freeze" for 2.2, it could be better to avoid changing this string (as I explained on c#6), but it's not a big deal.

Comment 9

[Evelyn Hung]

Comment on attachment 8570727 [details] [review]
[gaia] martasect:Bug_1136346 > mozilla-b2g:master

Although it's just a few string changes, I'd like to redirect to Arthur since I didn't follow this feature.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8570727 [details] [review]
[gaia] martasect:Bug_1136346 > mozilla-b2g:master

I remember that it is not required to change the string id when fixing capitalization. Stas, could you help confirm it? Thanks.

Comment 11

[Delphine Lebédel [:delphine - Use needinfo]]

(In reply to Arthur Chen [:arthurcc] from comment #10)
> Comment on attachment 8570727 [details] [review]
> [gaia] martasect:Bug_1136346 > mozilla-b2g:master
> 
> I remember that it is not required to change the string id when fixing
> capitalization. Stas, could you help confirm it? Thanks.

Arthur: Stas is on vacation until March 11th as mentioned in his bugzilla id. Theo actually answered this question already in comment 6.
FWIW, I don't think this needs to be a 2.2 blocker given the above. Thanks!

Comment 12

[Delphine Lebédel [:delphine - Use needinfo]]

Update: Privacy Panel has been removed from our 2.2 and 3.0 builds. So this is not a blocker (see Bug 1132377 for more details)

Comment 13

[Josh Cheng [:josh]]

Hi Delphine, 
Thank you for helping this.
Just a comment about "Privacy Panel has been removed from our 2.2 and 3.0 builds".

Privacy Panel is requested and developed by DT after 2.2 with no other operator nor OEM requested it. The decision is to make it pref off with bug 1132377. 

However DT will activate it once they want to launch device with FxOS 2.2. I am fine with not blocking this for 2.2 however it will block 2.2 for DT.

Currently the gaia owner for Privacy Panel is Marta ([e-mail]) from DT and Gecko is Dave Huseby ([e-mail]) from Mozilla. However they still need our help as 2.2 tight schedule. Thanks!

Comment 14

[Delphine Lebédel [:delphine - Use needinfo]]

Thanks for detailing Josh! I'm not sure what the ni on me is for though? Everything has been clearly explained by Theo in comment 6 I don't think I can act on anything :) please let me know! And please go ahead and block on this if it's necessary on DT side - that's not my call ;) thanks!

Comment 15

[Staś Małolepszy :stas]

Comment on attachment 8570727 [details] [review]
[gaia] martasect:Bug_1136346 > mozilla-b2g:master

Théo's comment 6 and Delphine's comment 11 already gave the right answer: no change to string id is needed.  I assume Théo f+ was a conditional one, given his comment is take into account.  Let me be a little bit more explicit and f- this: please don't change the string id here.  Changing it means more work for our localization community.

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8570727 [details] [review]
[gaia] martasect:Bug_1136346 > mozilla-b2g:master

Per comment 15, let's simply fix the string without changing the id.

Comment 17

[marta]

Comment on attachment 8570727 [details] [review]
[gaia] martasect:Bug_1136346 > mozilla-b2g:master

Reflagging, sorry for delay - still getting back from tonsillitis.

Comment 18

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8570727 [details] [review]
[gaia] martasect:Bug_1136346 > mozilla-b2g:master

No problem, take care! r=me.

Comment 19

[marta]

Kevin, can you land it, please?

Comment 20

[Francesco Lodolo [:flod]]

I think checkin-needed should make this land automatically

Comment 21

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/8db63896a36f0bf31afe3f2b7c45af19c1b91355

Comment 22

[Francesco Lodolo [:flod]]

Note that you need to request approval for 2.2

Comment 23

[marta]

Comment on attachment 8570727 [details] [review]
[gaia] martasect:Bug_1136346 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1136346
[User impact] if declined: 'Custom location' header is not consistent with other header capitalization; location is not capitalized. The UI will be inconsistent
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: yes

Comment 24

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/fcef5fce862570b8f66687b3a825329f47c44eb9