Closed Bug 1136601 Opened 9 years ago Closed 9 years ago

[Stingray] expose isVisible and focus API for update_manager

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: suchiu, Assigned: johnhu)

References

Details

Attachments

(1 file)

[gaia] huchengtw-moz:bug-1136601-api-for-update-manager > mozilla-b2g:master
46 bytes, text/x-github-pull-request
suchiu
: review+
Details | Review 
1. isVisible API: Determine whether this UI is visible or not, and return z-index.
2. focus API: Focus the default elementin this UI.
Blocks: 1136591
No longer blocks: 1136590
No longer depends on: 1136591
Summary: [Meta][Stingray] expose isVisible and focus API for update_manager → [Stingray] expose isVisible and focus API for update_manager
No longer blocks: 1136604
Assignee: nobody → im
Comment on attachment 8572515 [details] [review]
[gaia] huchengtw-moz:bug-1136601-api-for-update-manager > mozilla-b2g:master

Sung,

Please review this patch. Thanks.
Attachment #8572515 - Flags: review?(suchiu)
Comment on attachment 8572515 [details] [review]
[gaia] huchengtw-moz:bug-1136601-api-for-update-manager > mozilla-b2g:master

QA Gary had told me how to test this. I will make a test before put review flag.
Attachment #8572515 - Flags: review?(suchiu)
Comment on attachment 8572515 [details] [review]
[gaia] huchengtw-moz:bug-1136601-api-for-update-manager > mozilla-b2g:master

Please review this patch. Thanks.
Attachment #8572515 - Flags: review?(suchiu)
Depends on: 1139314
Comment on attachment 8572515 [details] [review]
[gaia] huchengtw-moz:bug-1136601-api-for-update-manager > mozilla-b2g:master

It looks good!!
Attachment #8572515 - Flags: review?(suchiu) → review+
merged to master:
https://github.com/mozilla-b2g/gaia/commit/a3f1840c69059634544539980b6698bb91b32991

gaia try is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=209003d4cbbc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: