1139314 - [Stingray] let focus manager to setTimeout, blur active and call focus of top most UI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

We use setTimeout to workaround the focus limitation of keyboard event. If we let every modules call their focus, we may have race condition when two modules try to show at the same time. Like, a permission manager and notification show at the same time and they all use setTimeout and focus to change the UI.

We should let focus manager to handle setTimeout and blur. Once they are done, we calculate the top most UI and call focus function of that UI.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] huchengtw-moz:bug-1139314-focus-manager-handle-timeout > mozilla-b2g:master

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8572999 [details] [review]
[gaia] huchengtw-moz:bug-1139314-focus-manager-handle-timeout > mozilla-b2g:master

Hi,

I had moved the setTimeout to focus manager to prevent race condition. Please review this patch. Thanks.

Comment 3

[Sung Chiu[:sungchiu]]

Comment on attachment 8572999 [details] [review]
[gaia] huchengtw-moz:bug-1139314-focus-manager-handle-timeout > mozilla-b2g:master

This patch looks good, thanks!!

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8572999 [details] [review]
[gaia] huchengtw-moz:bug-1139314-focus-manager-handle-timeout > mozilla-b2g:master

Sung,

I had changed the module list in focus manager. Please review this part. Thanks.

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8572999 [details] [review]
[gaia] huchengtw-moz:bug-1139314-focus-manager-handle-timeout > mozilla-b2g:master

Looks good! Thanks.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8572999 [details] [review]
[gaia] huchengtw-moz:bug-1139314-focus-manager-handle-timeout > mozilla-b2g:master

Sorry, please review this version since we found another case that we don't handle it very well.

Luke,

Please ask sung for more detail

Sung,
Please check if I miss anything and test app_authentication_dialog.js since it is modified by you.

Comment 7

[Sung Chiu[:sungchiu]]

Comment on attachment 8572999 [details] [review]
[gaia] huchengtw-moz:bug-1139314-focus-manager-handle-timeout > mozilla-b2g:master

This patch is good!

Comment 8

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8572999 [details] [review]
[gaia] huchengtw-moz:bug-1139314-focus-manager-handle-timeout > mozilla-b2g:master

r+, as we just discussed.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/d5c0a8dcb3ff193c801b9d84842777d157b48981

gaia try is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=056fbae344c9