1136988 - [Search] Shrinking graphic issue underneath the search overlay

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20150225_SearchOverlayGraphicIssue.txt

Description:
In multiple apps, the graphic contents get shirked and pushed up when the search overlay is open. This issue is observed in Dialer, Messages, Conacts, Clock, Music, etc.

Repro Steps:
1) Update a Flame to 20150225010244.
2) Open Phone app, and select dialer.
3) Tap on the rocket bar to bring up the search overlay and the keyboard.
4) Observe the dialer underneath.

Actual:
The dialer is shrinked and pushed up.

Expected:
No graphic change on Dialer underneath the search overlay.c

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150225010244
Gaia: f6bfd854fe4746f21bc006eac145365e85f98808
Gecko: 0a8b3b67715a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 10/10
See attached: screenshot, logcat

Comment 1

[Yeojin Chung [:YeojinC]]

This issue does not reproduces on Flame 2.1.

Result: No graphic changes underneath the search overlay.

Environmental Variables:
Device: Flame 2.1 (KK, 319mb, shallow flash)
BuildID: 20150223194120
Gaia: 86af0ca427adad12c3109124f31bef2fd9614e47
Gecko: a275f2c05ca6
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[Yeojin Chung [:YeojinC]]

Attachment: Shrinking.png

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

This looks pretty bad and it is a regression so nominating 2.2? Let's get a regression window.

Comment 4

[Brogan Zumwalt [Inactive]]

B2G-Inbound Regression Window:

Last working B2G-Inbound build:
Device: Flame 3.0
Build ID: 20150209023224
Gaia: bc052c237e0371e8c1d7286149cd854326ab1a52
Gecko: 96c0a16c31d0
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First broken B2G-Inbound build:
Device:  Flame 3.0
BuildID: 20150209051725
Gaia: be3a2109d78207e5cfae3ec4597b598dc827a96c
Gecko: c4863936edb8
Version: 38.0a1 (3.0)
Firmware: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Working Gaia with Broken Gecko issue does NOT reproduce:
Gaia: bc052c237e0371e8c1d7286149cd854326ab1a52
Gecko: c4863936edb8

Working Gecko with Broken Gaia issue DOES reproduce:
Gaia: be3a2109d78207e5cfae3ec4597b598dc827a96c
Gecko: 96c0a16c31d0


B2G-Inbound Pushlog:
https://github.com/mozilla-b2g/gaia/compare/bc052c237e0371e8c1d7286149cd854326ab1a52...be3a2109d78207e5cfae3ec4597b598dc827a96c


Issue appears to have been caused by changes made in bug 1126964

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

Dale, can you take a look at this please? It is possible that the landing and uplift for bug 1126964 might be the culprit here.

Comment 6

[Dale Harvey (:daleharvey)]

I dont think 1126964 caused this, the app windows are getting shrunk when the keyboard is focused in the search app, taking a look at what prevented this before but Alive guessing you may know of a change that could cause this?

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

If rocketbar tells HierarchyManager it is activated correctly, system-resize event will not be dispatched to AppWindowManager who will resize the active app.

I didn't see something break this in your patch in bug 1126964. Will investigate further.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Taking, this should be my issue.

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] alivedise:bugzilla/1136988/rocketbar-resize-app-window > mozilla-b2g:master

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8571788 [details] [review]
[gaia] alivedise:bugzilla/1136988/rocketbar-resize-app-window > mozilla-b2g:master

I must be drunken when I wrote the code.

Comment 11

[howie [:howie]]

Triage: regression blocking

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8571788 [details] [review]
[gaia] alivedise:bugzilla/1136988/rocketbar-resize-app-window > mozilla-b2g:master

r=me with a small nit

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/63737c8d053bcbccf58d34dc5586e9d7f1d3d63f

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8571788 [details] [review]
[gaia] alivedise:bugzilla/1136988/rocketbar-resize-app-window > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1096133
[User impact] if declined: User will notice the active app is being resized while using rocketbar
[Testing completed]: Y
[Risk to taking this patch] (and alternatives if risky): riskless - simple if/else statement change to detect rocketbar is active.
[String changes made]: NaN

Comment 16

[(PTO June 19-July 7) Ryan VanderMeulen]

v2.2: https://github.com/mozilla-b2g/gaia/commit/5df9a038343d35cab327c093dd08d1a59c9315ac

Comment 17

[Shine(Leave from Mozilla)]

Attachment: video

This problem is verified pass on latest build of Flame 3.0.
See attachment: Flame3.0_video.MP4
Rate:0/10
Leaving verifyme for 2.2 uplift/verification.

N5 v3.0 build (Pass):
Build ID               20150312160232
Gaia Revision          eabe35cf054d47087b37c1ca7db8143717fbd7f3
Gaia Date              2015-03-12 18:01:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/42afc7ef5ccb
Gecko Version          39.0a1
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150312.192453
Firmware Date          Thu Mar 12 19:25:12 EDT 2015
Bootloader             HHZ12d

Comment 18

[Hermes Cheng (inactive after July 27, 2015)]

(In reply to Shine from comment #17)
> Created attachment 8577154 [details]
> video
> 
> This problem is verified pass on latest build of Flame 3.0.
> See attachment: Flame3.0_video.MP4
> Rate:0/10
> Leaving verifyme for 2.2 uplift/verification.
> 
> N5 v3.0 build (Pass):
> Build ID               20150312160232
> Gaia Revision          eabe35cf054d47087b37c1ca7db8143717fbd7f3
> Gaia Date              2015-03-12 18:01:49
> Gecko Revision        
> https://hg.mozilla.org/mozilla-central/rev/42afc7ef5ccb
> Gecko Version          39.0a1
> Device Name            hammerhead
> Firmware(Release)      5.0
> Firmware(Incremental)  eng.cltbld.20150312.192453
> Firmware Date          Thu Mar 12 19:25:12 EDT 2015
> Bootloader             HHZ12d

Hi Shine, I saw your device name is "hammerhead" but not "flame". Could you clarify if there is any typo?

Besides, also verify this bug on flame v2.2. Thanks.

Comment 19

[Shine(Leave from Mozilla)]

(In reply to Hermes Cheng[:hermescheng] from comment #18)
> Hi Shine, I saw your device name is "hammerhead" but not "flame". Could you
> clarify if there is any typo?
Hi Hermses,
Thanks for your reminding! 
I'm sorry for confusion in the comment 17, please ignore the N5 v3.0 build version, i was verified the problem on Flame 3.0 device, the correct build version is:
Flame 3.0 build: (Pass)
Build ID               20150312160232
Gaia Revision          eabe35cf054d47087b37c1ca7db8143717fbd7f3
Gaia Date              2015-03-12 18:01:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/42afc7ef5ccb
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150312.194521
Firmware Date          Thu Mar 12 19:45:32 EDT 2015
Bootloader             L1TC000118D0

This problem is verified pass on latest build of Flame 2.2.
See attachment: Flame2.2_video.MP4
Rate:0/5
Flame 2.2 build: (Pass)
Build ID               20150319002500
Gaia Revision          9043c11f699c15bb6072422d1dad6518d1b5ddda
Gaia Date              2015-03-19 01:40:44
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c0442d170bec
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150319.042028
Firmware Date          Thu Mar 19 04:20:38 EDT 2015
Bootloader             L1TC000118D0

Comment 20

[Shine(Leave from Mozilla)]

Attachment: Flame2.2_video.MP4