1137097 - [Header] we don't recalculate when changing orientation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Components, defect)

Description

[Julien Wajsberg [:julienw]]

Gaia Header should listen to the orientationchange event and run runFontFitSoon.

See https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/Managing_screen_orientation#Listening_orientation_change for more information.

Comment 1

[Gregor Wagner [:gwagner]]

Blocking a blocker

Comment 2

[Bobby Chien]

Alive, could you help on this?

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Are you assigning me by a random choose?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Looks like :wilsonpage is the best guy

Comment 6

[Wilson Page [:wilsonpage]]

julien is going to take this as he is currently working on some other gaia-header improvements.

Comment 7

[Julien Wajsberg [:julienw]]

Attachment: font-fit PR

Comment 8

[Julien Wajsberg [:julienw]]

Attachment: gaia-header PR

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 8579666 [details] [review]
gaia-header PR

I realize I'd like to skip recalculating in 2 situations:
* when not-flush is used
* when innerWidth does not change

I'll finish this tomorrow.

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 8579666 [details] [review]
gaia-header PR

Hey Wilson,

I think this is now ready, tell me what you think :)

Comment 11

[Wilson Page [:wilsonpage]]

Comment on attachment 8579666 [details] [review]
gaia-header PR

Some questions and comments on pull-request.

Comment 12

[Julien Wajsberg [:julienw]]

Comment on attachment 8579666 [details] [review]
gaia-header PR

Ready for next review !

Comment 13

[Julien Wajsberg [:julienw]]

1st patch

font-fit master: https://github.com/gaia-components/font-fit/commit/9d00191f130a519e3688fca0cca5b8bf5b7a44c1
stamped 0.3.0: https://github.com/gaia-components/font-fit/commit/dc569f228c2e91fb8b698b44d0bf99b22db08a0d

Comment 14

[Wilson Page [:wilsonpage]]

Comment on attachment 8579666 [details] [review]
gaia-header PR

r+ (conditional)

All looks good apart from the `notFlush` part. Perhaps I'm missing something, I think the resize logic should be run in this case too.

Comment 15

[Julien Wajsberg [:julienw]]

Fixed the last comments and landed

gaia-header master: ee7e4f0b1ebe827bb38f67408e70e363c46061f2

Comment 16

[Julien Wajsberg [:julienw]]

gaia-header v0.8.0 stamp: 64da8f8103b21960230b2d6e3f2412e8441d052f

Comment 17

[Julien Wajsberg [:julienw]]

Attachment: gaia PR to ugprade gaia-geader

Comment 18

[Julien Wajsberg [:julienw]]

gaia master: https://github.com/mozilla-b2g/gaia/commit/869a9112a2f3c982362aeacb7187f56e05a5e801

Comment 19

[Julien Wajsberg [:julienw]]

Comment on attachment 8581788 [details] [review]
gaia PR to ugprade gaia-geader

[Approval Request Comment]
Note that this uplift is also necessary for bug 1140613.

[Bug caused by] (feature/regressing bug #): bug 1112131 (although I'm not really sure this specific bug is new)
[User impact] if declined: in these apps that handle both portrait and landscape orientations, we don't resize the text. It looks like this can lead to bugs like bug 1141832 as well.
[Testing completed]: yes (unit and manually)
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none


note that the same

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/ed1e0bd76c98babdfd94559c8f9d44921eec462d