cleanup obsolete "for each" loops in /mail/base/content/gloda*

RESOLVED FIXED in Thunderbird 39.0

Status

Thunderbird
Search
--
trivial
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 39.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

30.74 KB, patch
Magnus Melin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

3 years ago
When using the gloda faceted search, there is a ton of JS strict warnings about deprecated constructs, like this:

Warning: JavaScript 1.6's for-each-in loops are deprecated; consider using ES6 for-of instead
Source File: chrome://messenger/content/glodaFacetView.js
Line: 103, Column: 8
Source Code:
    for each (let [, groupValue] in Iterator(aGroupValues))
(Assignee)

Comment 1

3 years ago
Created attachment 8570182 [details] [diff] [review]
patch
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #8570182 - Flags: review?(mkmelin+mozilla)

Comment 2

3 years ago
Comment on attachment 8570182 [details] [diff] [review]
patch

Review of attachment 8570182 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #8570182 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 3

3 years ago
Thanks.
Keywords: checkin-needed
Summary: cleanup obsolete for each loops in /mail/base/content/gloda* → cleanup obsolete "for each" loops in /mail/base/content/gloda*

Comment 4

3 years ago
https://hg.mozilla.org/comm-central/rev/0a427480c7c3
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 39.0

Updated

2 years ago
Blocks: 1083470
You need to log in before you can comment on or make changes to this bug.