1138564 - L10N In Support Of FF37 What's new

Status: RESOLVED FIXED

(www.mozilla.org :: L10N, defect)

Description

[Ben (:bensternthal)]

== Wiki ==
https://wiki.mozilla.org/Websites/Mozilla.org/FFReleases/37

== Schedule ==
https://docs.google.com/a/mozilla.com/spreadsheets/d/1K17Po97qj3vV2BsB6CwWNLFBWYOxoQVYRD-XDWikIvY/edit?usp=sharing

Strings Ready For l10n: 2015-03-13
Launch Date: 2015-03-30

See user story whiteboard for locale list.

Comment 1

[Alex Gibson [:agibson]]

Quick question - if we're only localizing a small subset of locales for this whatsnew page, is this page being triggered in-product for only these locales above? If not, what should every other locale see?

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

I think release engineering can activate the What's New page for the set of locales we want and other locales wouldn't have a What's New page, pinging Sylvestre to know if this is possible.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Ben can probably answer to that question. We, release manager, don't manage the What's new page.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to Pascal Chevrel:pascalc from comment #2)
> I think release engineering can activate the What's New page for the set of
> locales we want and other locales wouldn't have a What's New page, pinging
> Sylvestre to know if this is possible.

Yeah, we can do this. We need to know the address of the whatsnew page and the locales that should have it *before* we build the release, though.

Comment 5

[Ben (:bensternthal)]

Sorry for the delay responding I was out sick yesterday.

We are targeting geo-graphical locations with this version of FF What's New. So the following is how this will work.

1. Whats New Turned On For All Users For FF37 Bug was filed a while ago See -> https://bugzilla.mozilla.org/show_bug.cgi?id=1134471
2. Web Site uses GeoDude (pmac advised here) to display this page to correction geo-graphical locations.
3. For folks not included in the Geo list, they are shown a (I still need to sort the details out here) one of our existing what's new pages. Although winston said he preferred if they were just shown the tab page.. but Im not sure if thats possible.

Comment 6

[Alex Gibson [:agibson]]

(In reply to Ben (:bensternthal) from comment #5)
> 3. For folks not included in the Geo list, they are shown a (I still need to
> sort the details out here) one of our existing what's new pages. Although
> winston said he preferred if they were just shown the tab page.. but Im not
> sure if thats possible.

Geo-location !== page locale.

Where a user is located in the world has no bearing to the language they have their browser set to. This will require us to translate this page for every locale, not just the list above.

We can either translate for all locales, or show this new page to only the subset above.

Comment 7

[Alex Gibson [:agibson]]

Working branch is: https://github.com/mozilla/bedrock/tree/bug-1134414-ff37-whatsnew-page

Template can be found at: https://github.com/mozilla/bedrock/blob/bug-1134414-ff37-whatsnew-page/bedrock/firefox/templates/firefox/whatsnew-fx37.html

This should contain the up-to-date strings in the copy doc found in Bug 1134401.

I'm still waiting on getting a demo server for this branch, but should hopefully have one soon and will update here.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Ben (:bensternthal) from comment #5)
> Sorry for the delay responding I was out sick yesterday.
> 
> We are targeting geo-graphical locations with this version of FF What's New.
> So the following is how this will work.
> 
> 1. Whats New Turned On For All Users For FF37 Bug was filed a while ago See
> -> https://bugzilla.mozilla.org/show_bug.cgi?id=1134471

This changes the scope of this project greatly, it's no longer a handful of locales we need but all of the locales supported by Firefox.

Comment 9

[Ben (:bensternthal)]

Pascal - we are working on a solution so that is not all locations but still the list we sent you originally. Once I have it all sorted I will update the bug.

Comment 10

[Alex Gibson [:agibson]]

Ok this is now up on a demo server:

https://www-demo3.allizom.org/en-US/firefox/37.0/whatsnew/

To the best of my knowledge all strings from Bug 1134401 are considered final, and should be in the template above for l10n.

Please note: this is just a basic template at the minute. The SMS form does not yet have plumbing, the email form just points to our regular newsletter still. The geo-location work has also yet to be implemented.

Comment 11

[Alex Gibson [:agibson]]

Ok looks like we are not quite yet string frozen - there may be one final addition we are waiting on: https://bugzilla.mozilla.org/show_bug.cgi?id=1134414#c6

Think we should be good to call string freeze on Friday - either Ben or myself will comment when we officially have the green light.

Comment 12

[Alex Gibson [:agibson]]

Another note:

When someone enters the sms number incorrectly, the server returns an error message like:

"Sorry. This number isn't valid. Please enter a U.S. phone number or<a href="http://mzl.la/OgZo6k">download directly from Google Play.</a>"

I asked pmac and he says bedrock returns a localized string here, so we don't need to include these in the template. But we should still make sure these error messages are translated in the languages we need.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Alex Gibson [:agibson] from comment #12)
> Another note:
> 
> When someone enters the sms number incorrectly, the server returns an error
> message like:
> 
> "Sorry. This number isn't valid. Please enter a U.S. phone number or<a
> href="http://mzl.la/OgZo6k">download directly from Google Play.</a>"
> 
> I asked pmac and he says bedrock returns a localized string here, so we
> don't need to include these in the template. But we should still make sure
> these error messages are translated in the languages we need.

Thanks Alex, I'll make sure to include this string in the lang file.

Comment 14

[Alex Gibson [:agibson]]

Ok we are good to call for string freeze, as per: https://bugzilla.mozilla.org/show_bug.cgi?id=1134401#c29

Comment 15

[Pascal Chevrel:pascalc (PTO until April 26)]

Strings sent to localizers, mini dashboard for this page: https://l10n.mozilla-community.org/~pascalc/langchecker/?locale=all&website=0&file=firefox/whatsnew-fx37.lang

Please note that we will translate German last as we will be using this page to test new volunteers in this language.

Comment 16

[Alex Gibson [:agibson]]

Geo-location is now in place on demo3, so only people in the US will be able to see the SMS form.

To help localizers outside of the US to test their changes, I've added a simple query param to enable showing the SMS form:

https://www-demo3.allizom.org/en-US/firefox/37.0/whatsnew/?geo=us

Comment 17

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Alex Gibson [:agibson] from comment #16)
> Geo-location is now in place on demo3, so only people in the US will be able
> to see the SMS form.
> 
> To help localizers outside of the US to test their changes, I've added a
> simple query param to enable showing the SMS form:
> 
> https://www-demo3.allizom.org/en-US/firefox/37.0/whatsnew/?geo=us

Great, thanks Alex! :)

Comment 18

[Alex Gibson [:agibson]]

Pascal, I'm still seeing the SMS error message in Comment 12 untranslated, e.g:

https://www-demo3.allizom.org/id/firefox/37.0/whatsnew/?geo=us

Maybe this string is just not yet completed, but I just want to make sure it doesn't slip through the cracks.

Comment 19

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Alex Gibson [:agibson] from comment #18)
> Pascal, I'm still seeing the SMS error message in Comment 12 untranslated,
> e.g:
> 
> https://www-demo3.allizom.org/id/firefox/37.0/whatsnew/?geo=us
> 
> Maybe this string is just not yet completed, but I just want to make sure it
> doesn't slip through the cracks.

The string is translated and in the lang file, it may be that the python file needing the string expects the string from one of the global UI files (main.lang, newsletter.lang) but I wouldn't want to add this string for translation to all locales while we are using it for just a subset of locales. Let me check locally.

Comment 20

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: form.diff

Alex, here is a patch adding the line needed in the python file to load the translations from the lang file (I can do a PR if needed)

Comment 21

[Alex Gibson [:agibson]]

(In reply to Pascal Chevrel:pascalc from comment #20)
> Created attachment 8579330 [details] [diff] [review]
> form.diff
> 
> Alex, here is a patch adding the line needed in the python file to load the
> translations from the lang file (I can do a PR if needed)

Many thanks Pascal, I should be able to see to adding this ok

Comment 22

[Alex Gibson [:agibson]]

Attachment: sms-error-message.png

Seeing the correct translated string now :)

Comment 23

[Alex Gibson [:agibson]]

Note: I've updated the PR to include strings for the og meta content, which we're recently added to main.lang in Bug 1140186.

Comment 24

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Pascal Chevrel:pascalc from comment #15)
> Strings sent to localizers, mini dashboard for this page:
> https://l10n.mozilla-community.org/~pascalc/langchecker/
> ?locale=all&website=0&file=firefox/whatsnew-fx37.lang
> 
> Please note that we will translate German last as we will be using this page
> to test new volunteers in this language.

All locales are translated, en-GB uses en-US strings as we recently added en-GB as a real locale on mozilla.org but don't have yet British localizers to actually fix spelling/reword strings currentlty in American English.

Marking fixed.