Closed Bug 1138870 Opened 7 years ago Closed 7 years ago

[Stingray] Move content of tv_shared folder to shared folder

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-picked<2015/11/9>])

Attachments

(1 file)

This is the required step before we could enable automatic test. Because currently we rely on build script to copy files from tv_shared to each apps. And build script would only do that with flag GAIA_DEVICE_TYPE=tv is set. And currently this flag is not set on TPBL.

By moving content of tv_shared to shared, we could utilize Gu and run unit test of tv_apps/
Assignee: nobody → tzhuang
There are six folders under tv_shared:
1. components
2. font
3. js
4. resources
5. style
6. test

I'll move components/ to shared/elements, because they are all web-components, and put 3,4,5,6 into corresponding directory under shared/. I think font/ should be also under shared/style/
(In reply to Tzu-Lin Huang [:dwi2][:tzhuang] from comment #1)
> I'll move components/ to shared/elements, because they are all
> web-components, and put 3,4,5,6 into corresponding directory under shared/.
> I think font/ should be also under shared/style/

Ni Wilson on component -- I think the intention was having things inside that folder managed by bower.
Flags: needinfo?(wilsonpage)
That would be a good idea. Here is a bug for tracking smart-screen components and make them managed by bower. https://bugzilla.mozilla.org/show_bug.cgi?id=1136509

We should fix that bug before fixing this.
Depends on: 1136509
Depends on: 1139731
Depends on: 1139773
Depends on: 1140982
Comment on attachment 8575223 [details] [review]
[gaia] dwi2:bug1138870 > mozilla-b2g:master

Hi Ricky, John,

Please help to review the patch. Thanks.

This patch did the following things:
1. Move everything under tv_apps/tv_shared/js/ to shared/js/
2. Move everything under tv_apps/tv_shared/style/ to shared/style/smart-screen/ because there is file name collision
3. Move everything under tv_apps/tv_shared/test/unit/mocks/ to shared/test/unit/mocks/
4. Move everything under tv_apps/tv_shared/resources/ to shared/resources/
5. Remove tv_apps/tv_shared/font/ and replace it with bower component https://github.com/smart-components/smart-icons. This will later merge with gaia-icons (see bug 1141425)
6. Remove tv_shared_helper.js
7. Remove almost every build/ directory of each app under tv_apps/, except smart-system
8. Adjust all affected paths in source code.
Attachment #8575223 - Flags: review?(ricky060709)
Attachment #8575223 - Flags: review?(im)
There is one more thing:

  tv_shared/ folder is history. (in the patch, for now :) )
Should we move the `tv_shared/` folder to `shared/tv/`??

We had put about 16+ files in `tv_shared/`. It would be good to have it owned folder.
Sorry, there is a typo at comment 7.

Should we move the `tv_shared/js/` folder to `shared/js/tv/`??
Comment on attachment 8575223 [details] [review]
[gaia] dwi2:bug1138870 > mozilla-b2g:master

r=rickychien, +1 with john's comment.
Attachment #8575223 - Flags: review?(ricky060709) → review+
Thanks, I'll move js files originally under tv_shared/js/ to shared/smart-screen/js/ to make it more consistent with shared/style/smart-screen/
Blocks: 1142372
Comment on attachment 8575223 [details] [review]
[gaia] dwi2:bug1138870 > mozilla-b2g:master

Looks good to me.
Attachment #8575223 - Flags: review?(im) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 1142956
Flags: needinfo?(wilsonpage)
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices][partner-cherry-picked<2015/11/9>]
You need to log in before you can comment on or make changes to this bug.