Closed Bug 1139731 Opened 9 years ago Closed 9 years ago

[Stingray] Use bower to manage evt.js

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

References

Details

(Whiteboard: [partner-cherry-picked<2015/11/5>])

Attachments

(1 file)

[gaia] dwi2:bug1139731 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review 
Since we already have evt.js at https://github.com/gaia-components/evt, we should use this version and let bower take care of dependency instead of using the one in tv_shared
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Comment on attachment 8573058 [details] [review]
[gaia] dwi2:bug1139731 > mozilla-b2g:master

Hi Rex,

Please help to review the patch, thanks.
Attachment #8573058 - Flags: review?(rexboy)
For those apps using components under tv_shared/components/, we will add bower dependency once smart-components are placed at https://github.com/gaia-components/
See Also: → 1139773
Comment on attachment 8573058 [details] [review]
[gaia] dwi2:bug1139731 > mozilla-b2g:master

Looks OK to me since we don't have no better way to incude bower packages for now.
Attachment #8573058 - Flags: review?(rexboy) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [partner-cherry-pick]
Whiteboard: [partner-cherry-pick] → [partner-cherry-picked<2015/11/5>]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: