Closed Bug 1139773 Opened 10 years ago Closed 10 years ago

[Stingray] Use bower to manage smart-components

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-picked<2015/11/5>])

Attachments

(1 file)

[gaia] dwi2:bug1139773 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review
Let bower take care of dependence on smart-components: 1. menu-group 2. smart-banner 3. smart-button And remove them from tv_shared/
See Also: → 1139731
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Comment on attachment 8573108 [details] [review] [gaia] dwi2:bug1139773 > mozilla-b2g:master Hi Rex, Please help to review the patch. If you think you are overloaded or JohnHu :johu is more suitable for reviewing this patch, feel free to redirect to :johu. Thanks
Attachment #8573108 - Flags: review?(rexboy)
By the way, this patch is based on bug 1139731, so the scope for the patch is only limited in the second commit (Bug 1139773 - [Stingray] Use bower to manage smart-components)
Comment on attachment 8573108 [details] [review] [gaia] dwi2:bug1139773 > mozilla-b2g:master Looks ok to me. You may need to make a note that the example of smart-menu uses smart-button as well.
Attachment #8573108 - Flags: review?(rexboy) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices][partner-cherry-picked<2015/11/5>]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: