1139577 - Support download 'hand-off'

Status: NEW

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Safari screenshot

Visit http://people.mozilla.org/~atrain/mobile/tests/test.zip

Nothing happens

Expected:

  Show the file and file-size and an 'Open In' button (see Safari)

Actual:

  Nothing happens

People download files browsers including Safari, we have to do something other than displaying nothing.

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Chrome screenshot

Looks like Chrome supports downloads all-together

Comment 2

[Darrin Henein [:darrin]]

I think Chrome just calls it downloads... it animates the file downloading and then presents the standard Open In... dialog (I suppose pre-downloading the file like that is nice?)

Good catch though Aaron!

Comment 3

[Eric Shepherd [:sheppy]]

Some browsers do in fact have a stash for putting downloads (Mercury Browser, for instance, does this). But IMHO handing them off to an appropriate app, if one exists, makes more sense.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/304

This isn't ready for review yet. Just putting it up for any feedback. This uses our SnackBars as a way to show downloads:

1.) We prompt for saving with a snackbar. If you select "Download", we
2.) use a different snackbar to show download progress. When its done, we
3.) use a third one to ask if you want to open it. Opening will (always) have options like Mail or Message so you can send the file to someone. Some other apps (IRCCloud for me) also appear as I have it now. 

video at https://dl.dropboxusercontent.com/u/72157/Downloads1.mov

This also makes it so that you can get to it downloaded files through iTunes File Sharing.

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 8588178 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/304

Working pretty well now. Updated snackbars to behave a little more like Android super toasts (button on the right) when there's only one button. Also using constraints better so the animations are smoother.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8588178 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/304

Wes can you please rebase this one before I look at it?

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Weird, the commits in this PR make no sense. Can you double check if this PR is correct?

Comment 8

[Wesley Johnston (:wesj)]

Grr. I rebased but then used commit --ammend which shoved my patch on top of head. I split things out a lot more here. My git patch-splitting skills are still... growing, so I see a few things still in the wrong place here (DownloadManager.swift is added to the project in the progress bar patch for example), and a few things that could be split up more. Hopefully its more readable though...

Comment 9

[Wesley Johnston (:wesj)]

I added in a beginBackgroundTask request commit here as well. That should keep us alive in the background for a bit longer (until the download is finished).

Comment 10

[Wesley Johnston (:wesj)]

Ping?

Comment 11

[Wesley Johnston (:wesj)]

Also, I should note that these downloads are stored in a different place than our normal profile. Our normal profile isn't easily exposed in iTunes as downloadable (not to say there aren't other things that will back it up or expose it, but it doesn't show up here).

I think I need to move these to a special "Downloads" folder so that its easy to cleanup/delete-them-all at times though.

Comment 12

[Wesley Johnston (:wesj)]

Talked to mfinkle about this a bit (and general worry about a new feature being added). If we punt on this, I think we at least need to show something on these types of links. An error page or a snackbar to say "Can't open this".

Comment 13

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Clearing needinfo because we are moving this to v1.1.

Comment 14

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8588178 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/304

Clearing review request because we are moving this to v1.1.

Comment 15

[Aaron Train [:aaronmt]]

Visit http://people.mozilla.org/~atrain/mobile/tests/test.zip (Content-Type: application/zip), we open the zip in the browser, potentially blowing bandwidth on a larger file for example. Expected to see an error if we won't hand off like Safari; please investigate bug 1159380 for 1.0

Comment 16

[Aaron Train [:aaronmt]]

"Open in Safari" does not work

https://bugzilla.mozilla.org/show_bug.cgi?id=1172958

Comment 17

[Aaron Train [:aaronmt]]

Because we have a string ".... we're working on it".

Comment 18

[Stephan Leroux [:sleroux]]

Let's create a feature card and add to our roadmap for future planning