Closed Bug 1159380 Opened 5 years ago Closed 5 years ago
Kill off loading files we can't show
Splitting off from bug 1139577. If we're punting on that, we need to show some errors when downloads fail. We could also offer to try and open the link in Safari for now?
Since this is replacing the old download bug, I think its +.
tracking-fennec: --- → +
I fixed this in bug 1125835
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Visit http://people.mozilla.org/~atrain/mobile/tests/test.zip (Content-Type: application/zip), we open the zip in the browser, potentially blowing bandwidth on a larger file for example. Expected to see an error if we won't hand off like Safari
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Erp. Removed this before the final patches. Thanks for checking. This shows an error page that says "Sorry :( Downloads aren't supported in Firefox yet" and has an "Open in Safari" button. Not sure if that's too whimsical or not :)
Attachment #8613024 - Flags: review?(sarentz)
Wes, you mention an error page, but in the patch I just see us cancel the request.
Summary: Show errors when we can't download → Kill off loading files we can't show
Comment on attachment 8613024 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/524 I changed the bug title to match the PR. Let me know if that is not correct.
Attachment #8613024 - Flags: review?(sarentz) → review+
Must have not pushed the changes (probably forgot the -f?) Updated now.
Can you re-review. Also pinging darrin for copy.
Looks good. Aaron can you test this with a few different files? And see how the error page interaction works?
Flags: needinfo?(sarentz) → needinfo?(aaron.train)
UI looks great. Matej, I like the tone here... anything you'd adjust? The emoticon is cute but looks odd in the flow?
Flags: needinfo?(dhenein) → needinfo?(matej)
(In reply to Darrin Henein [:darrin] from comment #10) > Created attachment 8616138 [details] > Screen Shot 2015-06-05 at 2.35.36 PM.png > > UI looks great. Matej, I like the tone here... anything you'd adjust? The > emoticon is cute but looks odd in the flow? Do we have to send people to Safari? On the one hand it's solving a problem for them, but on the other, it's Safari. Regardless, the copy could be: "Downloads aren't supported in Firefox yet (but we're working on it)." (We could also say "available" or "possible" instead of "supported," which sounds more technical.)
Thanks Matej! I think we should still punt them out to safari... better to let them complete their task elsewhere than not at all. Wes, let's go with: "Downloads aren't supported in Firefox yet (but we're working on it)."
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
"Open in Safari" does not work https://bugzilla.mozilla.org/show_bug.cgi?id=1172958
You need to log in before you can comment on or make changes to this bug.