1159380 - Kill off loading files we can't show

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Wesley Johnston (:wesj)]

Splitting off from bug 1139577. If we're punting on that, we need to show some errors when downloads fail. We could also offer to try and open the link in Safari for now?

Comment 1

[Wesley Johnston (:wesj)]

Since this is replacing the old download bug, I think its +.

Comment 2

[Wesley Johnston (:wesj)]

I fixed this in bug 1125835

Comment 3

[Aaron Train [:aaronmt]]

Visit http://people.mozilla.org/~atrain/mobile/tests/test.zip (Content-Type: application/zip), we open the zip in the browser, potentially blowing bandwidth on a larger file for example. Expected to see an error if we won't hand off like Safari

Comment 4

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/524

Erp. Removed this before the final patches. Thanks for checking. This shows an error page that says "Sorry :( Downloads aren't supported in Firefox yet" and has an "Open in Safari" button. Not sure if that's too whimsical or not :)

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Wes, you mention an error page, but in the patch I just see us cancel the request.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8613024 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/524

I changed the bug title to match the PR. Let me know if that is not correct.

Comment 7

[Wesley Johnston (:wesj)]

Must have not pushed the changes (probably forgot the -f?) Updated now.

Comment 8

[Wesley Johnston (:wesj)]

Can you re-review. Also pinging darrin for copy.

Comment 9

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Looks good. Aaron can you test this with a few different files? And see how the error page interaction works?

Comment 10

[Darrin Henein [:darrin]]

Attachment: Screen Shot 2015-06-05 at 2.35.36 PM.png

UI looks great. Matej, I like the tone here... anything you'd adjust? The emoticon is cute but looks odd in the flow?

Comment 11

[Matej Novak [:matej]]

(In reply to Darrin Henein [:darrin] from comment #10)
> Created attachment 8616138 [details]
> Screen Shot 2015-06-05 at 2.35.36 PM.png
> 
> UI looks great. Matej, I like the tone here... anything you'd adjust? The
> emoticon is cute but looks odd in the flow?

Do we have to send people to Safari? On the one hand it's solving a problem for them, but on the other, it's Safari.

Regardless, the copy could be:

"Downloads aren't supported in Firefox yet (but we're working on it)."


(We could also say "available" or "possible" instead of "supported," which sounds more technical.)

Comment 12

[Darrin Henein [:darrin]]

Thanks Matej! I think we should still punt them out to safari... better to let them complete their task elsewhere than not at all.

Wes, let's go with:

"Downloads aren't supported in Firefox yet (but we're working on it)."

Comment 13

[Aaron Train [:aaronmt]]

"Open in Safari" does not work

https://bugzilla.mozilla.org/show_bug.cgi?id=1172958