Closed Bug 1139603 Opened 5 years ago Closed 5 years ago

Fix -Winconsistent-missing-override warnings introduced in bug 940273

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

Bug 940273's commit ( http://hg.mozilla.org/mozilla-central/rev/b8dc4a7b444a ) introduced 3 -Winconsistent-missing-override build warnings (in clang 3.6 and newer), which are treated as errors in --enable-warnings-as-errors builds:

{
dom/cache/CacheParent.h:49:3: error: 'RecvPut' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]

   RecvPut(const RequestId& aRequestId, const CacheRequestResponse& aPut);
   ^
}

{
dom/cache/QuotaClient.cpp:197:3: error: 'AddRef' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]

   NS_INLINE_DECL_REFCOUNTING(CacheQuotaClient)
   ^
}


{
dom/cache/QuotaClient.cpp:197:3: error: 'Release' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
   NS_INLINE_DECL_REFCOUNTING(CacheQuotaClient)
   ^
}

Filing this bug on fixing those.
(I'm gonna land a fix with the blanket r+ that ehsan granted me for fixes of this sort over on bug 1126447 comment 2.)
Attached patch fixSplinter Review
Tree's closed at the moment; I'll land later.

Here's the fix, for the record.
https://hg.mozilla.org/mozilla-central/rev/76aa36cef867
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.