1139603 - Fix -Winconsistent-missing-override warnings introduced in bug 940273

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 940273's commit ( http://hg.mozilla.org/mozilla-central/rev/b8dc4a7b444a ) introduced 3 -Winconsistent-missing-override build warnings (in clang 3.6 and newer), which are treated as errors in --enable-warnings-as-errors builds:

{
dom/cache/CacheParent.h:49:3: error: 'RecvPut' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]

   RecvPut(const RequestId& aRequestId, const CacheRequestResponse& aPut);
   ^
}

{
dom/cache/QuotaClient.cpp:197:3: error: 'AddRef' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]

   NS_INLINE_DECL_REFCOUNTING(CacheQuotaClient)
   ^
}


{
dom/cache/QuotaClient.cpp:197:3: error: 'Release' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
   NS_INLINE_DECL_REFCOUNTING(CacheQuotaClient)
   ^
}

Filing this bug on fixing those.

Comment 1

[Daniel Holbert [:dholbert]]

(I'm gonna land a fix with the blanket r+ that ehsan granted me for fixes of this sort over on bug 1126447 comment 2.)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

Tree's closed at the moment; I'll land later.

Here's the fix, for the record.

Comment 3

[Daniel Holbert [:dholbert]]

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/76aa36cef867

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76aa36cef867