1139961 - Update universal download button to add link to App Store for iOS

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

This bug is opened to update the unversal download button to point to the App Store link for iOS users.

Set to launch May 12th FF38.

Comment 1

[Kohei Yoshino]

Like Google Play, we could replace the link with the itms-apps protocol for the App Store, on iOS devices.

https://github.com/mozilla/bedrock/blob/master/media/js/base/global.js#L51-L60
http://stackoverflow.com/questions/433907/how-to-link-to-apps-on-the-app-store

Comment 2

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Chris/Jen - do you envision us requiring a new string for the universal button for iOS?

Comment 3

[Jennifer Bertsch [:jbertsch]]

+Matej

Based on these styles: https://www.mozilla.org/en-US/styleguide/websites/sandstone/buttons/

I'm guessing we'll need "for iOS" (same string we'll need for the family nav) and possibly something like:
1.  Get if free in the App store ?
2.  for iOS 8.0 and above (or whatever that exact requirement is)

Comment 4

[Matej Novak [:matej]]

(In reply to Jennifer Bertsch [:jbertsch] from comment #3)
> +Matej
> 
> Based on these styles:
> https://www.mozilla.org/en-US/styleguide/websites/sandstone/buttons/
> 
> I'm guessing we'll need "for iOS" (same string we'll need for the family
> nav) and possibly something like:

Yes, "for iOS" sounds right to me.

> 1.  Get if free in the App store ?

Let's make it "Get it free from the App Store"

> 2.  for iOS 8.0 and above (or whatever that exact requirement is)

Do we have to do this here? We decided not to put it on the product page because the App Store will handle it.

Comment 5

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Okay cool.

So the final strings here are:

for iOS
Get it free from the App Store

:kohei - can I ask you to get these two strings in the template to expose for l10n for the 4/23 string freeze? It may need a waffle flag as the App itself won't be available until June 2nd, and the App Store URL is TBD still :/

Comment 6

[Kohei Yoshino]

Sure. Will do it tomorrow.

Comment 7

[Kohei Yoshino]

Attachment: pull request to expose strings

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/4b77c5025f130cefea14682ebb88b524cced09fa
Add strings for iOS download button, part of Bug 1139961

We need to expose those strings to meet the l10n string freeze on April
23. The logic behind the button is coming later.

https://github.com/mozilla/bedrock/commit/343102ef6b630d36cc38b7259cc7706b59956c8c
Merge pull request #2925 from kyoshino/bug-1139961-ios-button

Add strings for iOS download button, part of Bug 1139961

Comment 9

[Rebecca Billings [:rbillings]]

Let me know when/where this is ready for testing.

Comment 10

[Kohei Yoshino]

We still need the App Store URL but I'm about to work on the code. Done by next week, hopefully, using a placeholder URL.

Comment 11

[Kohei Yoshino]

Attachment: pull request

Comment 12

[Kohei Yoshino]

It might be better to file a new bug but what's the plan for the /firefox/new/ page? I'm basically copying the Android content/behaviour so there are a couple of new strings as you can see in my pull request, though the l10n string freeze has already passed:

* Looks like you’re using an older version of Firefox. Update on the App Store.
* Get Firefox on your iOS device
* Learn more about Firefox for Android (currently it says Mobile)
* Learn more about Firefox for iOS

:agibson says the first one may not be necessary as iOS apps are updated automatically, but in that case, what message should be presented to Firefox for iOS users?

Comment 13

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Hi Kohei!

We are no longer launching iOS for 38.0.5 (June 2). So, we have time to get these additional strings in.

Comment 14

[Kohei Yoshino]

That's a good news :)

Comment 15

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

We didn't ship iOS. Keeping the tracker open as it may prove helpful to use these bugs for reference when iOS does ship.

Comment 16

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Reopening this bug to support the V1 launch this quarter.

Comment 17

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Going to close this bug.

Per bug 1195369, we are going to auto redirect users to the product page as we do a phased rollout and the product page handles the geolocation.

This will most likely be needed for the global launch, and will be recreated accordingly.

Thanks!

Comment 18

[Craig Cook (:craigcook)]

Re-reopening for the global launch of Firefox for iOS.

Comment 19

[Rebecca Billings [:rbillings]]

I tested this on : https://www-demo1.allizom.org/en-US/firefox/ios/

* Entering a valid phone number [with and without "-"]shows this error:
Please make a selection before proceeding.

* Entering emails, the emails do not arrive [tested internal moz address & hotmail]

* This is the iTunes link, need confirmation that it's correct:
https://itunes.apple.com/app/apple-store/id989804926?pt=373246&mt=8&ct=mozorg-ios_page-appstore-button_sd

Comment 20

[Paul [:pmac] McLanahan]

For SMS we'll need a code change to support the iOS message. There is a list of messages allowed, and none of them are for iOS so far. Ben Niolet says that the ff-ios-download message is ready in basket, and I made sure it's also there in basket-dev.

For email the message ID for iOS (download-firefox-ios) is being sent, but may not exist in sandbox ET account. We'll need Ben to check on that (NI'd him).

Comment 21

[Paul [:pmac] McLanahan]

I'll also note that the page linked above (https://www-demo1.allizom.org/en-US/firefox/ios/) is pretty confusing as far as the nav goes. The links next to "Overview" (Sync and Private Browsing) are actually for desktop, and my understanding is that Fx iOS won't have tracking protection, which is the info you get on the private browsing page. Perhaps this is all in the works to fix, but I just wanted to be thorough.

Comment 22

[Ben Niolet]

The text for the SMS message needs changing. It's on my list and will happen asap. 

For email, the message ID download-firefox-ios is in basket-dev. The correct flag: DOWNLOAD_FIREFOX_IOS_FLG also exists on master_subscribers in sandbox.

Comment 23

[Ben Niolet]

BUT!!

There is no trigger setup in sandbox. Standby.

Comment 24

[Ben Niolet]

I just activated a quick trigger, tested and received it (en, html only). the email that sends is for an android download, but that's because we don't have the iOS creative built in Sandbox.

Comment 25

[Rebecca Billings [:rbillings]]

I checked out https://www-demo1.allizom.org/en-US/firefox/ios/ again. 
I received the Firefox Android download email at my moz.com email.
I did not receive the email at multiple hotmail/gmail addresses, after waiting 10+ minutes.

Comment 26

[Alex Gibson [:agibson]]

(In reply to Rebecca Billings [:rbillings] from comment #19) 
> * Entering a valid phone number [with and without "-"]shows this error:
> Please make a selection before proceeding.

I can reproduce this locally also - It looks like we're still missing the relevant bits for the iOS SMS messages to work: https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/views.py#L106-L110

Pmac, I seem to remember we had most of this set up before the first iOS launch was delayed. Is it just a case of adding the right values for the iOS platform to bedrock here?

As a side note, is this the best bug to be talking about send-to-device? This bug is more for the download button which is kinda separate.

Comment 27

[Paul [:pmac] McLanahan]

(In reply to Alex Gibson [:agibson] from comment #26)
> I can reproduce this locally also - It looks like we're still missing the
> relevant bits for the iOS SMS messages to work:
> https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/views.py#L106-
> L110
> 
> Pmac, I seem to remember we had most of this set up before the first iOS
> launch was delayed. Is it just a case of adding the right values for the iOS
> platform to bedrock here?

That's my recollection as well. It used to work, but I guess was removed before launch w/o iOS.

> As a side note, is this the best bug to be talking about send-to-device?
> This bug is more for the download button which is kinda separate.

A good point. I've not seen any other bugs about this page, so I dunno. Is there another bug for this Cory? Mind filing one if not?

Comment 28

[Alex Gibson [:agibson]]

I filed bug 1223813 for adding the iOS identifier for the SMS messaging to work correctly.

Comment 29

[Rebecca Billings [:rbillings]]

Verified on dev that SMS functions, and emails are sent/received. I'm still wondering about Comment 21 and the Sync/Private Browsing links displayed with iOS.

Comment 30

[Alex Gibson [:agibson]]

(In reply to Rebecca Billings [:rbillings] from comment #29)
> I'm still wondering about Comment 21 and the Sync/Private Browsing links displayed with iOS.

As far as I understand this is by design. Firefox for iOS has Sync, and while it does not have Tracking Protection just yet, it does have Private Browsing mode.

Comment 31

[Rebecca Billings [:rbillings]]

The sent email is still for Firefox Android- this needs to be updated.

Comment 32

[Rebecca Billings [:rbillings]]

I was testing on demo & dev- bniolet confirmed that the forms are correct on stage & send FF iOS emails (although it is not visible, testing was done using curl).

Comment 33

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/403b7463f51f054b5ce3f00fb3a1271d3a6a29b9
Fix Bug 1139961 - Update universal download button to add link to App Store for iOS

Props to Kohei

https://github.com/mozilla/bedrock/commit/70e90cede47239a671dad20b1b94dd2ee585197e
Merge pull request #3542 from mozilla/bug-1139961-ios-download-button

Fix Bug 1139961 - Update universal download button to add link to App…