1217929 - Clean up waffle dependencies after Fx iOS global launch

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Craig Cook (:craigcook)]

Most of the updates we're making for the global release of Firefox for iOS are being held behind the waffle switch 'firefox-ios-global' to give us some control over the timing of those changes going live. Once the global release happens, though, the waffle switch will become redundant because the changes should then be permanent.

Filing this bug to remind myself to go back through and clean up dependencies on that waffle switch, both to make the changes permanent and to remove some of the pre-iOS-global legacy code we'll no longer need.

Checklist:

* Fx Family Nav - iOS becomes permanent
* Fx Family Page - iOS becomes permanent, clean up CSS for the old three-product layout
* Fx iOS Product Page - remove the geolocation logic, newsletter signup, beta flag
* Download button - iOS becomes permanent
* Firefox /new page - iOS becomes permanent, remove redirect
* Fx iOS home page promo - iOS becomes permanent (sort of; promos change frequently but this shouldn't need waffle)

Comment 1

[Schalk Neethling [:espressive]]

Waffle will also need to be removd from the /choose page - https://bugzilla.mozilla.org/show_bug.cgi?id=1214822#c9

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/1e0dde650d132f9b1626cfed90881f12d9fcb5f5
Fix bug 1217929 - Clean up iOS waffle dependencies

https://github.com/mozilla/bedrock/commit/cff134c64d7222a6069d7ad4d43252720fb0a429
Merge pull request #3689 from craigcook/bug-1217929-ios-waffle-cleanup

Fix bug 1217929 - Clean up iOS waffle dependencies