1140129 - [e10s] Tab title not always updated

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Vladan Djeric (:vladan)]

Sometimes, when I open Google Calendar (as a signed in user), the tab's title remains stuck on the page's URL and never updates to "Mozilla - Calendar". 

- There are no relevant errors or warnings in the browser console
- I can't reproduce this anymore, but I've seen it several times in the past
- Installed extensions: Send Tab to Device, Pocket
- I suspect this is e10s related but I'm not 100% sure

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I've seen this kind of a lot recently.

Comment 2

[juan becerra [:juanb]]

I haven't noticed this problem, but I have noticed a related issue on Mac where opening the calendar page will show the tab title, but after a minute or so the page will do some fetching, and then the tab title will change to the URL. It won't display a "Mozilla - Calendar" tab title until you refresh the page.

If you try this on a non-e10s window, you don't see this problem.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I can also reproduce this on Google Calendar. I suspect that this is happening when the content updates the URL by changing the anchor.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Needinfo'ing myself to see if this is related or can be fixed together with bug 1129564

Comment 5

[Mike Conley (:mconley) (:⚙️)]

My suspicion might be incorrect - updating the anchor via different means (<a href="#foo">, location.replace, location.hash, etc) don't seem to cause the bug to show. Odd.

Comment 6

[:Felipe Gomes (needinfo for replies!)]

I needinfo'ed myself to see if this was related to bug 1129564 - the conclusion is that it isn't.

Comment 7

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

This was annoying me so I looked into it. The problem is that we can get onLocationChange events even when we're not navigating (changing the hash part of the URL for example). In that case we don't want to clear the title.

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 8589972 [details] [diff] [review]
patch

Review of attachment 8589972 [details] [diff] [review]:
-----------------------------------------------------------------

Ah of course!

Comment 9

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00edb9fedb4c

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/00edb9fedb4c