Closed Bug 1140300 Opened 10 years ago Closed 10 years ago

[Stingray][Component] Reveal dependency of smart-button in smart-banner example page

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dwi2, Unassigned)

References

Details

Attachments

(1 file)

pull request
55 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review
In smart-banner example page, we also use smart-button for demonstration. We should reveal this information in both documentation and bower.json.
Same to evt.js.
Attached file pull request —
Hi Rex, This is follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1139773#c4 Please help to review it, thanks
Attachment #8573809 - Flags: review?(rexboy)
Comment on attachment 8573809 [details] [review] pull request Looks good to me. Thanks!
Attachment #8573809 - Flags: review?(rexboy) → review+
Landed on smart-components:master https://github.com/smart-components/smart-banner/commit/f1d0e0987fb37330823c5e2568f40fa0f71c5fe6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 1218722
No longer blocks: 1218722
Blocks: 1219540
No longer blocks: 1219540
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: