If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Ignore attempts to share e10s tabs

VERIFIED FIXED in Firefox 38

Status

Hello (Loop)
Client
P1
normal
Rank:
3
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: mikedeboer, Assigned: mikedeboer)

Tracking

unspecified
mozilla39
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(e10sm6+, firefox38 fixed, firefox39 verified)

Details

(Whiteboard: [screensharing])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
For browser tabs that are running in separate content process (e10s, or 'remote' tabs), we don't support tab/ browser sharing yet.

See bug 1137634 for more details about this issue.

For the interim, we must ignore tab sharing requests for e10s tabs.

We'll add a user-friendly error message for >=Fx39 in a separate bug.
Flags: qe-verify+
Flags: firefox-backlog+
(Assignee)

Updated

3 years ago
Summary: Ignore requests for e10s tab sharing attempts → Ignore attempts to share e10s tabs
Whiteboard: [screensharing]
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8574659 [details] [diff] [review]
Patch v1: ignore attempts to share e10s tabs in a Hello conversation
Attachment #8574659 - Flags: review?(standard8)
(Assignee)

Comment 2

3 years ago
Created attachment 8574668 [details] [diff] [review]
Patch v1.1: ignore attempts to share e10s tabs in a Hello conversation
Attachment #8574659 - Attachment is obsolete: true
Attachment #8574659 - Flags: review?(standard8)
Attachment #8574668 - Flags: review?(standard8)
(Assignee)

Updated

3 years ago
Depends on: 1141072

Updated

3 years ago
Rank: 3
Depends on: 1137634
(Assignee)

Updated

3 years ago
Blocks: 1115336
Comment on attachment 8574668 [details] [diff] [review]
Patch v1.1: ignore attempts to share e10s tabs in a Hello conversation

Review of attachment 8574668 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I noticed that if you're on a non-e10s tab and switch to an e10s tab, then you don't get an error. I think we'll just have to live with it, as this should only be temporary anyway.

::: browser/components/loop/MozLoopAPI.jsm
@@ +292,5 @@
>            listener(cloneValueInto(err, targetWindow));
>            return;
>          }
> +        if (browser.getAttribute("remote") == "true") {
> +          // Tab sharing is not supported yet for e10s-enabled browsers.

Please reference the bug here.
Attachment #8574668 - Flags: review?(standard8) → review+
(Assignee)

Comment 4

3 years ago
Pushed to fx-team with comment addressed: https://hg.mozilla.org/integration/fx-team/rev/8b8f9dee8fd3
(Assignee)

Updated

3 years ago
Iteration: 38.2 - 9 Feb → 39.2 - 23 Mar

Updated

3 years ago
tracking-e10s: --- → m6+
https://hg.mozilla.org/mozilla-central/rev/8b8f9dee8fd3
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: mozilla38 → mozilla39
(Assignee)

Comment 6

3 years ago
Comment on attachment 8574668 [details] [diff] [review]
Patch v1.1: ignore attempts to share e10s tabs in a Hello conversation

Approval Request Comment
[Feature/regressing bug #]: Loop/ Hello screensharing milestone
[User impact if declined]: User will see a new option that allows her/ him to share a window or Firefox tabs inside a room (aka. conversation).
[Describe test coverage new/current, TreeHerder]: landed on m-c, tests pass.
[Risks and why]: minor
[String/UUID change made/needed]: n/a
Attachment #8574668 - Flags: approval-mozilla-aurora?
Attachment #8574668 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox38: --- → affected
(Assignee)

Comment 7

3 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/6c5849a66b1a
status-firefox38: affected → fixed
QA Contact: bogdan.maris
Did some exploratory testing around this on Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5 using latest Nightly and can confirm that tab sharing is ignored on e10s tabs. 
Whenever I try to share a e10s tab I get the following error message: 
> 'Error: Tab sharing is not supported for e10s-enabled browsers'
Status: RESOLVED → VERIFIED
status-firefox39: fixed → verified
This applies only to nightly and was already verified there, so removing the qe-verify flag as verification in 38 is not needed.
Flags: qe-verify+
Depends on: 1154511
No longer depends on: 1154511
You need to log in before you can comment on or make changes to this bug.