1141059 - Ignore attempts to share e10s tabs

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mike de Boer [:mikedeboer]]

For browser tabs that are running in separate content process (e10s, or 'remote' tabs), we don't support tab/ browser sharing yet.

See bug 1137634 for more details about this issue.

For the interim, we must ignore tab sharing requests for e10s tabs.

We'll add a user-friendly error message for >=Fx39 in a separate bug.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: ignore attempts to share e10s tabs in a Hello conversation

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1.1: ignore attempts to share e10s tabs in a Hello conversation

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8574668 [details] [diff] [review]
Patch v1.1: ignore attempts to share e10s tabs in a Hello conversation

Review of attachment 8574668 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I noticed that if you're on a non-e10s tab and switch to an e10s tab, then you don't get an error. I think we'll just have to live with it, as this should only be temporary anyway.

::: browser/components/loop/MozLoopAPI.jsm
@@ +292,5 @@
>            listener(cloneValueInto(err, targetWindow));
>            return;
>          }
> +        if (browser.getAttribute("remote") == "true") {
> +          // Tab sharing is not supported yet for e10s-enabled browsers.

Please reference the bug here.

Comment 4

[Mike de Boer [:mikedeboer]]

Pushed to fx-team with comment addressed: https://hg.mozilla.org/integration/fx-team/rev/8b8f9dee8fd3

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8b8f9dee8fd3

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8574668 [details] [diff] [review]
Patch v1.1: ignore attempts to share e10s tabs in a Hello conversation

Approval Request Comment
[Feature/regressing bug #]: Loop/ Hello screensharing milestone
[User impact if declined]: User will see a new option that allows her/ him to share a window or Firefox tabs inside a room (aka. conversation).
[Describe test coverage new/current, TreeHerder]: landed on m-c, tests pass.
[Risks and why]: minor
[String/UUID change made/needed]: n/a

Comment 7

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6c5849a66b1a

Comment 8

[Bogdan Maris, Desktop Test Engineering]

Did some exploratory testing around this on Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5 using latest Nightly and can confirm that tab sharing is ignored on e10s tabs. 
Whenever I try to share a e10s tab I get the following error message: 
> 'Error: Tab sharing is not supported for e10s-enabled browsers'

Comment 9

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

This applies only to nightly and was already verified there, so removing the qe-verify flag as verification in 38 is not needed.