Closed Bug 1141059 Opened 5 years ago Closed 5 years ago

Ignore attempts to share e10s tabs

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
2

Tracking

(e10sm6+, firefox38 fixed, firefox39 verified)

VERIFIED FIXED
mozilla39
Iteration:
39.2 - 23 Mar
Tracking Status
e10s m6+ ---
firefox38 --- fixed
firefox39 --- verified

People

(Reporter: mikedeboer, Assigned: mikedeboer)

References

Details

(Whiteboard: [screensharing])

Attachments

(1 file, 1 obsolete file)

For browser tabs that are running in separate content process (e10s, or 'remote' tabs), we don't support tab/ browser sharing yet.

See bug 1137634 for more details about this issue.

For the interim, we must ignore tab sharing requests for e10s tabs.

We'll add a user-friendly error message for >=Fx39 in a separate bug.
Flags: qe-verify+
Flags: firefox-backlog+
Summary: Ignore requests for e10s tab sharing attempts → Ignore attempts to share e10s tabs
Whiteboard: [screensharing]
Status: NEW → ASSIGNED
Attachment #8574659 - Attachment is obsolete: true
Attachment #8574659 - Flags: review?(standard8)
Attachment #8574668 - Flags: review?(standard8)
Depends on: 1141072
Rank: 3
Blocks: 1115336
Comment on attachment 8574668 [details] [diff] [review]
Patch v1.1: ignore attempts to share e10s tabs in a Hello conversation

Review of attachment 8574668 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I noticed that if you're on a non-e10s tab and switch to an e10s tab, then you don't get an error. I think we'll just have to live with it, as this should only be temporary anyway.

::: browser/components/loop/MozLoopAPI.jsm
@@ +292,5 @@
>            listener(cloneValueInto(err, targetWindow));
>            return;
>          }
> +        if (browser.getAttribute("remote") == "true") {
> +          // Tab sharing is not supported yet for e10s-enabled browsers.

Please reference the bug here.
Attachment #8574668 - Flags: review?(standard8) → review+
Pushed to fx-team with comment addressed: https://hg.mozilla.org/integration/fx-team/rev/8b8f9dee8fd3
Iteration: 38.2 - 9 Feb → 39.2 - 23 Mar
https://hg.mozilla.org/mozilla-central/rev/8b8f9dee8fd3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: mozilla38 → mozilla39
Comment on attachment 8574668 [details] [diff] [review]
Patch v1.1: ignore attempts to share e10s tabs in a Hello conversation

Approval Request Comment
[Feature/regressing bug #]: Loop/ Hello screensharing milestone
[User impact if declined]: User will see a new option that allows her/ him to share a window or Firefox tabs inside a room (aka. conversation).
[Describe test coverage new/current, TreeHerder]: landed on m-c, tests pass.
[Risks and why]: minor
[String/UUID change made/needed]: n/a
Attachment #8574668 - Flags: approval-mozilla-aurora?
Attachment #8574668 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
QA Contact: bogdan.maris
Did some exploratory testing around this on Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5 using latest Nightly and can confirm that tab sharing is ignored on e10s tabs. 
Whenever I try to share a e10s tab I get the following error message: 
> 'Error: Tab sharing is not supported for e10s-enabled browsers'
Status: RESOLVED → VERIFIED
This applies only to nightly and was already verified there, so removing the qe-verify flag as verification in 38 is not needed.
Flags: qe-verify+
No longer depends on: 1154511
You need to log in before you can comment on or make changes to this bug.