Closed
Bug 1141815
Opened 11 years ago
Closed 11 years ago
remove nsIDOMCryptoDialogs interface and associated implementation
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: keeler, Assigned: Cykesiopka)
References
Details
Attachments
(1 file)
|
13.80 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
AFAICT, nsIDOMCryptoDialogs is no longer used and can be removed. It looks like the associated UI can be removed as well (security/manager/pki/resources/content/escrowWarn.xul, any "escrowWarn" strings, etc.)
|
Assignee | |
Comment 1•11 years ago
|
||
Try push looks good so far: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5c9b74ceb14
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Attachment #8575906 -
Flags: review?(dkeeler)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8575906 [details] [diff] [review]
bug1141815_rm-nsIDOMCryptoDialogs_v1.patch
Review of attachment 8575906 [details] [diff] [review]:
-----------------------------------------------------------------
Great - thanks.
Attachment #8575906 -
Flags: review?(dkeeler) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Thanks for the review.
(Try push is in comment 1. Rather red for OSX, but that's either due to infra, or whatever the cause of Bug 1142006 is)
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•