1142568 - Clean up global scope pollution from browser-social.js

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: SocialAPI, defect)

Description

[Dão Gottwald [:dao]]

browser-social.js does this:

(function() {

XPCOMUtils.defineLazyModuleGetter(this, "PanelFrame",
  "resource:///modules/PanelFrame.jsm");

XPCOMUtils.defineLazyGetter(this, "OpenGraphBuilder", function() {
  let tmp = {};
  Cu.import("resource:///modules/Social.jsm", tmp);
  return tmp.OpenGraphBuilder;
});
...

})();

As it stands, the anonymous function is completely pointless, and all the lazy getters (PanelFrame, OpenGraphBuilder, DynamicResizeWatcher, sizeSocialPanelToContent, CreateSocialStatusWidget, CreateSocialMarkWidget, hookWindowCloseForPanelClose) leak into the browser window's global scope ("this") which is shared with lots of other scripts.

Comment 1

[Dão Gottwald [:dao]]

browser-social.js is gone.