Closed Bug 1143239 Opened 5 years ago Closed 5 years ago

Add missing MOZ_OVERRIDE to ClientReadbackLayer.h

Categories

(Core :: Graphics: Layers, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Recently-introduced build warning, hit by clang 3.6 and newer:
(and treated as an errorr in warnings-as-errors builds)
{
In file included from $SRC/gfx/layers/client/ClientLayerManager.cpp:23:
$SRC/gfx/layers/client/ClientReadbackLayer.h:27:18: error: 'AsLayer' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  virtual Layer* AsLayer() { return this; }
                 ^
../../dist/include/mozilla/layers/ShadowLayers.h:424:18: note: overridden virtual function is here
  virtual Layer* AsLayer() = 0;
                 ^
}

and:
{
In file included from $SRC/gfx/layers/client/ClientLayerManager.cpp:23:
$SRC/gfx/layers/client/ClientReadbackLayer.h:28:16: error: 'RenderLayer' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  virtual void RenderLayer() {}
               ^
$SRC/gfx/layers/client/ClientLayerManager.h:378:16: note: overridden virtual function is here
  virtual void RenderLayer() = 0;
               ^
}

I think this was introduced incidentally by bug 1132432 (which added a correctly MOZ_OVERRIDE annotated function, which made this class "inconsistent" & hence tripped clang's "Winconsistent-missing-override" warning)
(I'm gonna land a fix with the blanket r+ that ehsan granted me for fixes of
this sort over on bug 1126447 comment 2.)
Blocks: buildwarning
Assignee: nobody → dholbert
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/83cad68b776f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.