1143239 - Add missing MOZ_OVERRIDE to ClientReadbackLayer.h

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Daniel Holbert [:dholbert]]

Recently-introduced build warning, hit by clang 3.6 and newer:
(and treated as an errorr in warnings-as-errors builds)
{
In file included from $SRC/gfx/layers/client/ClientLayerManager.cpp:23:
$SRC/gfx/layers/client/ClientReadbackLayer.h:27:18: error: 'AsLayer' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  virtual Layer* AsLayer() { return this; }
                 ^
../../dist/include/mozilla/layers/ShadowLayers.h:424:18: note: overridden virtual function is here
  virtual Layer* AsLayer() = 0;
                 ^
}

and:
{
In file included from $SRC/gfx/layers/client/ClientLayerManager.cpp:23:
$SRC/gfx/layers/client/ClientReadbackLayer.h:28:16: error: 'RenderLayer' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  virtual void RenderLayer() {}
               ^
$SRC/gfx/layers/client/ClientLayerManager.h:378:16: note: overridden virtual function is here
  virtual void RenderLayer() = 0;
               ^
}

I think this was introduced incidentally by bug 1132432 (which added a correctly MOZ_OVERRIDE annotated function, which made this class "inconsistent" & hence tripped clang's "Winconsistent-missing-override" warning)

Comment 1

[Daniel Holbert [:dholbert]]

(I'm gonna land a fix with the blanket r+ that ehsan granted me for fixes of
this sort over on bug 1126447 comment 2.)

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83cad68b776f

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/83cad68b776f