1143567 - Ensure that non-APZ input events have any APZ transform applied

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Even if events aren't processed by APZ, we still need to fix their reference point to account for any async transforms.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 1, DispatchInputEvent

Add the DispatchInputEvent call which will make sure the event goes through APZ first.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 2, fix gtk

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 3, clean up nsWindow dispatch

This cleans up the Dispatch*Event functions in nsWindow so they take the actual type they're supposed to. Predictably there were paths with bad casts.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 4, fix Windows

Ensure that anything dispatching a WidgetInputEvent routes through DispatchInputEvent, which applies an APZ transform if one exists.

After the cleanup these are the only places (I think) that dispatch a WidgetInputEvent.

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8577913 [details] [diff] [review]
part 3, clean up nsWindow dispatch

Review of attachment 8577913 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/winrt/MetroWidget.cpp
@@ +667,1 @@
>    mEventQueue.Push(newEvent);

mEventQueue.Push(cmdEvent);

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/5e93ac53e79c
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d47ee5553045
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/311dd54d806b
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/1727096f4b48

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e93ac53e79c
https://hg.mozilla.org/mozilla-central/rev/d47ee5553045
https://hg.mozilla.org/mozilla-central/rev/311dd54d806b
https://hg.mozilla.org/mozilla-central/rev/1727096f4b48

Comment 8

[Gary [:streetwolf52]]

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1144081 for a possible regression due to this patch.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d45aaa6d2217

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4510d4116527