1144509 - timeupdate event isn't fired before seeked event

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

Per HTMLMediaElement spec:
http://www.w3.org/html/wg/drafts/html/master/semantics.html#seeking

"4.8.14.9 Seeking
16. ⌛ Queue a task to fire a simple event named timeupdate at the element.
17. ⌛ Queue a task to fire a simple event named seeked at the element.
"

The event timeupdate isn't fired.

This cause failure of the media-source/mediasource-duration.html test

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Part1. Fire timeupdate before seeked event as per spec

fire timeupdate before seeked event.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Part2. Update webref tests

update test. We don't pass on linux and webm as we fail an assert to calculate the duration of the video (6.042 vs 6.045)

Comment 3

[Karl Tomlinson (:karlt)]

Should the test be re-enabled on Mac now?
Perhaps win too?

Comment 4

[Jean-Yves Avenard [:jya]]

There's more failure with the two following tests, they timeout.

I have found the cause for those (tracked in bug 1143971 and bug 1144617)

Comment 5

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/749fd9127c14
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6c200ffc985f

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/749fd9127c14
https://hg.mozilla.org/mozilla-central/rev/0abff0bf399a

Comment 7

[Jean-Yves Avenard [:jya]]

I believe this should be uplifted for 38.

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8579129 [details] [diff] [review]
Part1. Fire timeupdate before seeked event as per spec

Approval Request Comment
[Feature/regressing bug #]: MSE and HTML5 video
[User impact if declined]: Spec compliance, possible stalls after seeking.
[Describe test coverage new/current, TreeHerder]: Landed on m-c, web platform tests.
[Risks and why]: Risk is low. We just queue the missing event, which should have no harmful side-effects.
[String/UUID change made/needed]: None.

Comment 9

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f80361d0ef39

Comment 10

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2e4d058161b2

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Windows permafail on Aurora:
https://treeherder.mozilla.org/logviewer.html#?job_id=715812&repo=mozilla-aurora

Comment 12

[Jean-Yves Avenard [:jya]]

You need bug 1142433 uplifted...

Comment 13

[Ralph Giles (:rillian)]

I believe jya addressed this.