The Reading List button from the Location Bar is available for in-content pages

VERIFIED FIXED in Firefox 39

Status

Firefox Graveyard
Reading List
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: avaida, Assigned: florian)

Tracking

(Blocks: 1 bug)

39 Branch
Firefox 39
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify +

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.25 KB, text/plain
florian
: review+
Details
Reproducible on:
Nightly 39.0a1 (2015-03-18)

Affected platforms:
Ubuntu 14.04 (x64), Windows 7 (x64), Mac OS X 10.9.5.

Preconditions:
* browser.readinglist.enabled = true

Steps to reproduce:
1. Launch Firefox.
2. Access an in-content page, (e.g.) about:preferences.
3. Check the Location Bar.

Expected result:
There's no "Add page to Reading List" button displayed in the Location Bar for this type of pages.

Actual result:
* The "Add page to Reading List" button is displayed in the Location Bar for in-content pages too.
* Clicking the button does nothing and has no visual feedback for the end user.
* Clicking the button results in the following error getting thrown in the Browser Console:
> TypeError: document.getItems is not a function PageMetadata.jsm:125:39
Flags: qe-verify+
(Assignee)

Comment 1

3 years ago
Created attachment 8580252 [details] [diff] [review]
Patch

This patch also fixes bug 1144684.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8580252 - Flags: review?(mhammond)
Hi Florian, can you provide a point value.
Iteration: --- → 39.2 - 23 Mar
Flags: needinfo?(florian)
Flags: firefox-backlog+
(Assignee)

Updated

3 years ago
Points: --- → 3
Flags: needinfo?(florian)
Comment on attachment 8580252 [details] [diff] [review]
Patch

Review of attachment 8580252 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-readinglist.js
@@ +279,5 @@
>     */
>    togglePageByBrowser: Task.async(function* (browser) {
> +    let uri = browser.currentURI;
> +    if (uri.spec.startsWith("about:reader?"))
> +      uri = ReaderParent.parseReaderUrl(uri.spec);

check null here
Attachment #8580252 - Flags: review?(mhammond) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8580267 [details]
Patch v2

Null check added.
Attachment #8580252 - Attachment is obsolete: true
Attachment #8580267 - Flags: review+

Updated

3 years ago
Blocks: 1132074
QA Contact: andrei.vaida
https://hg.mozilla.org/mozilla-central/rev/fafaf621ada2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Verified fixed on Nightly 39.0a1 (2015-03-23), using Ubuntu 14.04 (x64), Mac OS X 10.9.5 and Windows 7 (x64), with all the pages listed in about:about.

Please note that Reader View is still available across platforms for the about:credits page, which redirects the user to https://www.mozilla.org/credits/. I think that's expected - Florian, what's your take on this?
Status: RESOLVED → VERIFIED
status-firefox39: fixed → verified
Flags: needinfo?(florian)
(Assignee)

Comment 8

3 years ago
(In reply to Andrei Vaida, QA [:avaida] from comment #7)

> Please note that Reader View is still available across platforms for the
> about:credits page, which redirects the user to
> https://www.mozilla.org/credits/. I think that's expected - Florian, what's
> your take on this?

Seems fine to me; thanks for checking! :)
Flags: needinfo?(florian)
Verified fixed on Aurora 38.0a2 (2015-03-29) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5, with all the pages from about:about.
status-firefox38: fixed → verified
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.