1144684 - The status of Reading List's button from the Location Bar is not syncing with the one from Reader View's controls

Status: VERIFIED FIXED

(Firefox Graveyard :: Reading List, defect)

Description

[Andrei Vaida [:avaida]]

Attachment: screenshot from Ubuntu 14.04 (x64)

Reproducible on:
Nightly 39.0a1 (2015-03-18)

Affected platforms:
Ubuntu 14.04 (x64), Windows 7 (x64), Mac OS X 10.9.5.

Preconditions:
* browser.readinglist.enabled = true
* reader.parse-on-load.enabled = true

Steps to reproduce:
1. Launch Firefox.
2. Access a Reader View compatible web page, (e.g.) https://www.mozilla.org/en-US/mission/.
3. Click the "Enter Reader View" button from the Location Bar.
4. From Reader View's controls bar, click the "Add to Reading List" button.
5. Check the status of the "Add page to Reading List" button from the Location Bar.

Expected result:
Clicking the "Add to Reading List" button from Reader View also turns the "Add page to Reading List" button to the active/enabled state.

Actual result:
* The "Add page to Reading List" button status doesn't sync with the one from Reader View.
* The same goes for adding a web page to Reading List from the Location Bar and removing it from Reader View's controls sidebar.
* Also, this way, you can add the same page to Reading List twice, once from the Location Bar and the second time from Reader View.

Comment 1

[Tim Nguyen :ntim]

Clicking the urlbar plus icon seems to add `about:reader?url=MY_URL` to the reading list, while the button in the reader view sidebars adds MY_URL itself.

Comment 2

[Florian Quèze [:florian]]

(In reply to Tim Nguyen [:ntim] from comment #1)
> Clicking the urlbar plus icon seems to add `about:reader?url=MY_URL` to the
> reading list, while the button in the reader view sidebars adds MY_URL
> itself.

This is indeed the problem. I included a fix for this in my patch for bug 1144680.

Comment 4

[Florian Quèze [:florian]]

Fixed in bug 1144680.

Comment 5

[Andrei Vaida [:avaida]]

The verification of this fix is currently blocked by Bug 1146358.

Comment 6

[Andrei Vaida [:avaida]]

The verification of this fix has been covered by the testing performed on Bug 1146358.