114520 - Can't Delete Imported IE Favorites Folder

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[eberry]

A recent regression.  My IE favorites folder can't be deleted when using
2001-12-10-03 under W2K.  There is no delete context menu item, and the del key
doesn't work.  Other bookmarks/folders can be deleted fine.  Similarly, the
"Open in New Window" context menu item does nothing for IE Favorites.  It works
for normal folders.

Comment 1

[Boris Zbarsky [:bzbarsky]]

To blake.... this sounds like his doing.

Comment 2

[Michael Baffoni]

I see this too on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.6+)
Gecko/2001121203.  The delete button gets greyed out when the folder or it's
children are selected.

Comment 3

[R.K.Aa.]

*** Bug 115575 has been marked as a duplicate of this bug. ***

Comment 4

[Gilles Durys]

*** Bug 115827 has been marked as a duplicate of this bug. ***

Comment 5

[Skewer]

I'm seeing this in 2001122208 WinXP. Except that instead of an IE favorites
folder, I have a useless bookmark that does nothing, and I still can't delete
it. This problem irritates me just as much as it did the last time, upgrading
things a bit.

Comment 6

[Skewer]

I figured out the useless bookmark thing, discussion of that will take place in
bug 116712.

Comment 7

[Chris Lyon]

*** Bug 116638 has been marked as a duplicate of this bug. ***

Comment 8

[Daniel Jensen]

This isn't just a Win2K/XP bug. It hits all the Windows variants I know of
except 3.1. :|  Is this platform dependent? Does anyone know about its Linux status?

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 117470 has been marked as a duplicate of this bug. ***

Comment 10

[Gordon Shephard]

I've had a lot of challenges deleting imported bookmarks.  Mozilla/5.0 (Windows;
U; Windows NT 5.0; en-US; rv:0.9.7) Gecko/20011221 still is having issues.

The behaviour is interesting.  For any link that starts with "https://" the
delete button isn't greyed out.  For a link that begins with file:/// (And I
have no idea why they were imported in that format, I.E.
file:///C|/Documents%20and%20Settings/shephard/Favorites/Links/perl.url
)the delete button isn't greyed out.

In neither case does hitting the delete key on the keyboard do anything.

Let me know if you'd like a copy of my bookmarks file, for me to do more
testing, reimport my bookmarks, import a different set of bookmarks, try out a
new release, etc....

Comment 11

[Olav Vitters]

*** Bug 118371 has been marked as a duplicate of this bug. ***

Comment 12

[Peter Trudelle]

This is particularly painful now that I have imported my 1,500 NS bookmarks into
IE.  BTW, why are these called "imported" anyway, *I* didn't import them.  Could
more accurately be called *Imposed* IE Favorites.

Comment 13

[peganthyrus]

It does the same thing in the Mac OSX (2001122106) version: a thoroughly empty
'Imported IE Favorites' folder, that cannot be deleted.

Comment 14

[Hixie (not reading bugmail)]

I probably semi-caused this -- when I changed the bookmarks menus, I made the
sidebar and the personal toolbar have the same menu, and I picked the wrong one.

I'll attach a patch which removes the IE favourites folder's Open In New Window
and Copy commands (sine they don't work) and adds a Delete command (since it
should work).

Someone please test this as I am on Linux and don't _have_ an IE favourites
folder to test with.

Comment 15

[Hixie (not reading bugmail)]

Attachment: Patch 1.0

Comment 16

[Hixie (not reading bugmail)]

Note that this won't fix the other problems mentioned above such as the https://
vs file:// issues and the reasons behind Open In New Window not working and in
fact the whole way IE favourites are implemented...

Comment 17

[Hixie (not reading bugmail)]

Attachment: Patch 1.1

The previous patch didn't work because the delete item was disabled for the IE
favourites bookmark. Let's try enabling it.

Comment 18

[Peter Van der Beken [:peterv]]

Comment on attachment 64807 [details] [diff] [review]
Patch 1.1

r=peterv

Comment 19

[jag (Peter Annema)]

Comment on attachment 64807 [details] [diff] [review]
Patch 1.1

sr=jag

Comment 20

[Daniel Dvorkin]

This problem also exists in Mozilla 0.9.7 running under MacOS 9.1.

Comment 21

[eberry]

Fixed with 2002-01-15-03 under W2K.

Comment 22

[gavin long]

*** Bug 120391 has been marked as a duplicate of this bug. ***

Comment 23

[Olav Vitters]

*** Bug 120740 has been marked as a duplicate of this bug. ***

Comment 24

[Boris Zbarsky [:bzbarsky]]

*** Bug 124060 has been marked as a duplicate of this bug. ***

Comment 25

[Boris 'pi' Piwinger]

In 0.9.8 I now can delete the IE folder -> suggesting VERIFIED.