Closed Bug 1145372 Opened 5 years ago Closed 5 years ago

The add to reading list url bar button is larger than the other url bar buttons

Categories

(Firefox Graveyard :: Reading List, defect)

x86
All
defect
Not set

Tracking

(firefox38 verified, firefox39 verified)

VERIFIED FIXED
Firefox 39
Tracking Status
firefox38 --- verified
firefox39 --- verified

People

(Reporter: florian, Assigned: florian)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
The height/width of the add/remove icons for the readinglist were set to 16px in bug 1131457. The other toolbar buttons in the url bar have 14px icons.

Also, currently we've got more whitespace between the 'add to read list' and 'reader mode' icon than between other url bar icons.

On Mac the padding between the other icons is 3px (which is done by having padding start + padding end = 3px: http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css?rev=fcb1fc9a00e7#2408).

Not requesting review yet because I need to check how things look on Windows/Linux.
Attached patch Patch v2Splinter Review
This patch copies the padding values from the #urlbar > toolbarbutton rules of browser.css on the various platforms. I verified that it looks reasonable on Mac and Linux. The Linux and Windows values seem identical, so hopefully it'll be good there too :).
Assignee: nobody → florian
Attachment #8580303 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8580314 - Flags: review?(mhammond)
Attachment #8580314 - Flags: review?(mhammond) → review+
Flags: qe-verify+
QA Contact: andrei.vaida
https://hg.mozilla.org/mozilla-central/rev/cc408bbacbd9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Hi Florian, can you provide a point value.
Blocks: 1132074
Iteration: --- → 39.2 - 23 Mar
Flags: needinfo?(florian)
Flags: firefox-backlog+
Note for QA: verifying a build with this specific patch isn't useful, because the code to show this icon has just changed significantly again with bug 1145909.
Points: --- → 2
Flags: needinfo?(florian)
Verified fixed on Nightly 39.0a1 (2015-03-23), using Ubuntu 14.04 (x64), Mac OS X 10.9.5 and Windows 7 (x64). 

The Reading List button is displayed properly, smaller in size and padding - according to the specifications mentioned in Comment 0.
Status: RESOLVED → VERIFIED
Verified fixed on Aurora 38.0a2 (2015-03-29) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.