1145372 - The add to reading list url bar button is larger than the other url bar buttons

Status: VERIFIED FIXED

(Firefox Graveyard :: Reading List, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch

The height/width of the add/remove icons for the readinglist were set to 16px in bug 1131457. The other toolbar buttons in the url bar have 14px icons.

Also, currently we've got more whitespace between the 'add to read list' and 'reader mode' icon than between other url bar icons.

On Mac the padding between the other icons is 3px (which is done by having padding start + padding end = 3px: http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css?rev=fcb1fc9a00e7#2408).

Not requesting review yet because I need to check how things look on Windows/Linux.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch v2

This patch copies the padding values from the #urlbar > toolbarbutton rules of browser.css on the various platforms. I verified that it looks reasonable on Mac and Linux. The Linux and Windows values seem identical, so hopefully it'll be good there too :).

Comment 2

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/cc408bbacbd9

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cc408bbacbd9

Comment 4

[Marco Mucci [:MarcoM]]

Hi Florian, can you provide a point value.

Comment 5

[Florian Quèze [:florian]]

Note for QA: verifying a build with this specific patch isn't useful, because the code to show this icon has just changed significantly again with bug 1145909.

Comment 6

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 39.0a1 (2015-03-23), using Ubuntu 14.04 (x64), Mac OS X 10.9.5 and Windows 7 (x64). 

The Reading List button is displayed properly, smaller in size and padding - according to the specifications mentioned in Comment 0.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/73a88d5a05d3

Comment 8

[Andrei Vaida [:avaida]]

Verified fixed on Aurora 38.0a2 (2015-03-29) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.